[Bionic][PATCH 1/3] powerpc/crash: Remove the test for cpu_online in the IPI callback

Joseph Salisbury joseph.salisbury at canonical.com
Fri Mar 30 19:44:28 UTC 2018

From: Balbir Singh <bsingharora at gmail.com>

BugLink: http://bugs.launchpad.net/bugs/1758206

Our check was extra cautious, we've audited crash_send_ipi
and it sends an IPI only to online CPU's. Removal of this
check should have not functional impact on crash kdump.

Signed-off-by: Balbir Singh <bsingharora at gmail.com>
Reviewed-by: Nicholas Piggin <npiggin at gmail.com>
Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
(cherry picked from commit 04b9c96eae72d862726f2f4bfcec2078240c33c5)
Signed-off-by: Joseph Salisbury <joseph.salisbury at canonical.com>
 arch/powerpc/kernel/crash.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
index cbabb5a..29c56ca 100644
--- a/arch/powerpc/kernel/crash.c
+++ b/arch/powerpc/kernel/crash.c
@@ -69,9 +69,6 @@ static void crash_ipi_callback(struct pt_regs *regs)
 	int cpu = smp_processor_id();
-	if (!cpu_online(cpu))
-		return;
 	if (!cpumask_test_cpu(cpu, &cpus_state_saved)) {
 		crash_save_cpu(regs, cpu);

More information about the kernel-team mailing list