[bionic][PATCH 00/10] Add drivers for RTL8821C WiFi and BT

Seth Forshee seth.forshee at canonical.com
Tue Mar 27 14:10:40 UTC 2018


On Sat, Mar 24, 2018 at 12:46:57AM +0800, Wen-chien Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1740231
> BugLink: https://launchpad.net/bugs/1742613
> 
> These are based on the drivers provided by Realtek for 4.13.
> 
> Since btusb will bind to this bluetooth device, it must be blacklisted
> in btusb to make sure that the correct driver is used. Also the table in
> ubuntu/rtl8821c-bt is modified so that the driver works only for this
> device only.
> 
> Risk should be low since both drivers have no impact for systems without
> these devices.

This is a driver with almost 600,000 lines of code, submitted at the
last minute without any explanation of why we should be adding it to our
kernel. Please explain why this is needed.

Some of my objections/questions from just a quick skim:

 - Being built with our kernel, the driver will be signed and thus
   eligible to be loaded during secure boot. There's no chance that we
   can review it to ensure that it doesn't expose any unsafe interfaces
   to userspace. Have you done such a review?

 - Why does this need to hook into our debian build scripts rather than
   being built like a normal module?

 - You blacklist usb device 0bda:b00a for all architectures but only
   build the replacement driver for x86. Is there any chance someone
   might want to use the device with another architecture? If so you'll
   be breaking them.

 - Presumably we'll have to keep maintaining this huge pile of code for
   years into the future, up to and including the next LTS I expect.

Thanks,
Seth




More information about the kernel-team mailing list