ACK/cmnt: [SRU][Artful][Bionic][PATCH 0/3] Fixes for LP:1747572

[Stefan Bader]

On 09.03.2018 09:33, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1747572
> 
> == SRU Justification ==
> CIFS SMB2/SMB3 does not work for domain based DFS.  The bug reporter is 
> having problems mounting a domain based DFS share using mount.cifs with the 
> parameter vers=2.0 or vers=3.0, even though it works with the deprecated 
> version vers=1.0.
> 
> This bug was reported and fixed upstream by the requested three commits:
> https://bugzilla.samba.org/show_bug.cgi?id=12917
> 
> The three requested commits are all in mainline as of v4.16-rc1.
> 
> == Fixes ==
> b327a717e506 ("CIFS: make IPC a regular tcon")
> 63a83b861c47 ("CIFS: use tcon_ipc instead of use_ipc parameter of SMB2_ioctl")
> 02cf5905e35d ("CIFS: dump IPC tcon in debug proc file")
> 
> == Regression Potential ==
> Low.  Limited to cifs.

I am not sure that this is a low. CIFS is one of the rather more often used
network file systems. And fixing one case may break other use cases. On the pro-
side the suggested picks come from upstream. It was verified to at least fix the
issue. But I still suggest we carefully scan incoming issues for Samba bugs (as
well as keep an eye on 4.15.y upstream stable).

With adjusted risk:

Acked-by: Stefan Bader <stefan.bader at canonical.com>

> 
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Aurelien Aptel (3):
>   CIFS: make IPC a regular tcon
>   CIFS: use tcon_ipc instead of use_ipc parameter of SMB2_ioctl
>   CIFS: dump IPC tcon in debug proc file
> 
>  fs/cifs/cifs_debug.c |  61 ++++++++++++---------
>  fs/cifs/cifsglob.h   |  14 ++---
>  fs/cifs/cifssmb.c    |   7 +--
>  fs/cifs/connect.c    | 150 ++++++++++++++++++++++++++++++++++++++-------------
>  fs/cifs/inode.c      |   2 +-
>  fs/cifs/smb2file.c   |   2 +-
>  fs/cifs/smb2ops.c    |  53 ++++++++----------
>  fs/cifs/smb2pdu.c    |  40 ++++----------
>  fs/cifs/smb2proto.h  |   3 +-
>  9 files changed, 193 insertions(+), 139 deletions(-)
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180312/229225f5/attachment.sig>