ACK/cmnt: [Xenial SRU][PATCH 0/4] Redpine: wowlan enhancements

Stefan Bader stefan.bader at
Mon Mar 12 10:08:11 UTC 2018

On 05.03.2018 13:40, Amitkumar Karwar wrote:
> From: Amitkumar Karwar <amit.karwar at>
> This patch series adds deep sleep power save feature. Device will be
> put in low power state in disconnected state. It also includes fixes
> for the issues observed during S4 suspend and resume
> Prameela Rani Garnepudi (2):
>   UBUNTU: SAUCE: Redpine: resolve race while resuming from S4
>   UBUNTU: SAUCE: Redpine: Fix card write failure issue at S4 restore
> Sanjay Kumar Konduri (2):
>   UBUNTU: SAUCE: Redpine: Add deep sleep enable before connection
>   UBUNTU: SAUCE: Redpine: resolve power save issue after S4 resume
>  ubuntu/rsi/rsi_91x_mac80211.c | 19 ++++++++++++++++---
>  ubuntu/rsi/rsi_91x_mgmt.c     | 21 +++++++++++++++------
>  ubuntu/rsi/rsi_91x_ps.c       |  2 +-
>  ubuntu/rsi/rsi_91x_sdio.c     |  3 +--
>  ubuntu/rsi/rsi_main.h         |  1 +
>  5 files changed, 34 insertions(+), 12 deletions(-)

Since this is an additional driver which will not impact generic code I will not
insist on strict procedure. But the way that bug reports are used in this SRU
requests is very confusing to me who is not involved in the project that much.

Of the 4 patches, 3 seem to be very clearly related to s4 issues. And the short
description of the one other patch sounds like power states related, too. But
all 4 patches have BugLinks for an S4 issues (ok) and one about beacon scanning
frequency (no idea how that is related to the s4 issues or the patches).
Normal SRU requests try to fix one issue (possibly with multiple individual
patches). That one submissions refers to multiple bug reports should be a rare
case when one change fixes various symptoms.

Anyhow, as said, I do not think its worth more delay, ... this time.

Acked-by: Stefan Bader <stefan.bader at>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <>

More information about the kernel-team mailing list