ACK: [SRU][Artful][Bionic][linux-oem][PATCH] Fix a wrong FIXUP for alc289 on Dell machines

Colin Ian King colin.king at canonical.com
Sat Mar 3 14:01:53 UTC 2018


On 03/03/18 13:45, Hui Wang wrote:
> BugLink: https://launchpad.net/bugs/1748807
> 
> This patch is based on the two patches of
> https://lists.ubuntu.com/archives/kernel-team/2018-February/090186.html, the two
> patches are not sufficient to fix headset-mic problem on the machine with the
> codec alc289, with those two patches, the driver can detect that the headset-mic
> is plugged, but can't record sound with headset-mic.
> 
> Thanks to Kailang at realtek, he pointed out that FIXUP for alc289 is wrong, so
> we need to apply this new patch to fix the problem.
> 
> [Test Case]
> plug the headset and record the sound on the machine with the codec alc289
> 
> [Fix]
> one commit from alsa repository, and this commit will be merged to upstream soon.
> 
> [Regression Potential]
> very low, since this patch only change the FIXUP for the Dell machines with
> alc289, and we already verified both plug detection and recording sound work
> well with the new patch.
> 
> Hui Wang (1):
>   ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines
> 
>  sound/pci/hda/patch_realtek.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Has positive test results, limited to specific hardware so regression
potential is very limited.

Acked-by: Colin Ian King <colin.king at canonical.com>




More information about the kernel-team mailing list