ACK/cmnt: [PATCH][T/X/A SRU] UBUNTU: [Packaging] git-ubuntu-log -- fix detection of packaging changes
stefan.bader at canonical.com
Fri Mar 2 09:17:57 UTC 2018
On 28.02.2018 17:12, Seth Forshee wrote:
> The recent update to handle multiple bugs/cves has an error in
> the detection of packaging changes, causing them to be denoted as
> upstream changes in the changelog. Change this logic to check the
> subject field instead of the non-existent title field.
> Ignore: yes
> Signed-off-by: Seth Forshee <seth.forshee at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
I guess I have to trust you on this (as setting title is something new I
believe), but we should notice wrong or right quickly.
I am a bit confused now about Thadeu's reply to have applied it to Bionic but
that should not ürevent this from going into the other branches that got the
> debian/scripts/misc/git-ubuntu-log | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/debian/scripts/misc/git-ubuntu-log b/debian/scripts/misc/git-ubuntu-log
> index e428e5727911..490ecce73c48 100755
> --- a/debian/scripts/misc/git-ubuntu-log
> +++ b/debian/scripts/misc/git-ubuntu-log
> @@ -23,7 +23,7 @@ def add_entry(entry):
> combo = sorted(combo)
> if len(combo) == 0:
> - if entry.get('title', "").startswith('UBUNTU'):
> + if entry.get('subject', "").startswith('UBUNTU'):
> combo = '__packaging__'
> combo = '__mainline__'
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: OpenPGP digital signature
More information about the kernel-team