NACK: [kteam-tools][PATCH] start-sru-cycle: change backports / derivatives format in tracking bug description

[Kleber Souza]

On 01/16/18 09:14, Po-Hsu Lin wrote:
> Now the backports / derivatives in tracking bug description looks like:
> backports: 1743363,1743364
> derivatives: 1743365,1743367,1743368,1743369,1743370,174337
> 
> Add a 'bug' string before the bug number for launchpad to treat it as a link.
> Add a '(package-name)' after it, so we could know what it is from a glance.
> 
> The new style is expected to be:
> backports: bug 1743363 (linux-aws), bug 1743364 (linux-lts-xenial)
> derivatives: bug 1743365 (linux-aws), bug 1743367 (linux-euclid), bug 1743368 (linux-gke)...
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
> ---
>  stable/start-sru-cycle | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/stable/start-sru-cycle b/stable/start-sru-cycle
> index 0cd58778..695ed849 100755
> --- a/stable/start-sru-cycle
> +++ b/stable/start-sru-cycle
> @@ -116,7 +116,7 @@ class Crankers():
>                              print('     -> EE: Bug creation failed (does the package exist in the archive?)!')
>                              continue
>                          bug.tags.append(cycle_tag)
> -                        backports.append(str(bug.id))
> +                        backports.append('bug {} ({})'.format(str(bug.id), backport_project))
>                          bug.tags.append('kernel-sru-backport-of-%s' % master_bug.id)
>  
>                      derivatives = []
> @@ -127,13 +127,13 @@ class Crankers():
>                              print('     -> EE: Bug creation failed (does the package exist in the archive?)!')
>                              continue
>                          bug.tags.append(cycle_tag)
> -                        derivatives.append(str(bug.id))
> +                        derivatives.append('bug {} ({})'.format(str(bug.id), derivative_project))
>                          bug.tags.append('kernel-sru-derivative-of-%s' % master_bug.id)
>  
>                      description = master_bug.description
>                      description += '\n'
> -                    description += 'backports: %s\n' % ','.join(backports)
> -                    description += 'derivatives: %s\n' % ','.join(derivatives)
> +                    description += 'backports: %s\n' % ', '.join(backports)
> +                    description += 'derivatives: %s\n' % ', '.join(derivatives)
>                      master_bug.description = description
>  
>              retval = 0
> 

These changes have already been made as part of:

commit 9620e8e049455f37eee64b811294eda56603d02f
Author: Andy Whitcroft <apw at canonical.com>
Date:   Tue Feb 27 12:33:19 2018 +0000

    start-sru-cycle: convert to KernelSeries


Thanks,
Kleber