NACK: [Xenial SRU][PATCH v2] UBUNTU: SAUCE: Redpine: fix soft-ap invisible issue

[Stefan Bader]

On 21.06.2018 09:35, Shrirang Bagul wrote:
> On Wed, 2018-06-13 at 20:24 +0530, Siva Rebbagondla wrote:
>> From: Sanjay Kumar Konduri <sanjay.konduri at redpinesignals.com>
>>
>> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
>>
>> Observed third party station is unable to scan redpine AP, when soft-ap
>> wizard invoked. This is because power save is not disabled for soft-ap
>> mode. Hence, disabling power save for soft-ap mode.
>>
>> Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri at redpinesignals.com>
>> Signed-off-by: Siva Rebbagondla <siva.rebbagondla at redpinesignals.com>
>> ---
>> v2: Added enhancement for soft-ap [Shrirang]

What? Why? And you realize that NACKing should rather be done *before* we
applied it?

-Stefan
>> ---
>>  ubuntu/rsi/rsi_91x_mac80211.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
>> index bae06e3..4e0c2ae 100644
>> --- a/ubuntu/rsi/rsi_91x_mac80211.c
>> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
>> @@ -565,8 +565,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>>  		return;
>>  	}
>>  	if ((!bss->assoc) &&
>> -	    (adapter->ps_state == PS_ENABLED) &&
>> -	    (vif->type == NL80211_IFTYPE_STATION))
>> +	    (adapter->ps_state == PS_ENABLED))
>>  		rsi_disable_ps(adapter);
>>  	if(ieee80211_is_auth(wlh->frame_control))
>>  		common->mac_ops_resumed = false;
>> @@ -860,6 +859,7 @@ static int rsi_mac80211_change_interface(struct ieee80211_hw *hw,
>>  
>>  	switch (newtype) {
>>  		case NL80211_IFTYPE_AP:
>> +			rsi_disable_ps(adapter);
>>  			ven_rsi_dbg(INFO_ZONE, "Change to AP Mode\n");
>>  			intf_mode = AP_OPMODE;
>>  			break;
>>
>>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180621/f841e56c/attachment.sig>