ACK: [kteam-tools][PATCH 0/2] debian.py: fix changelog[content, bugs] off-by-one

Stefan Bader stefan.bader at canonical.com
Mon Jun 18 15:29:26 UTC 2018


On 15.06.2018 22:44, Kamal Mostafa wrote:
> PATCH 1/2: debian.py: fix changelog[content,bugs] off-by-one
> 
> The debian changelog parser in debian.py (both implementations) is bugged
> such that the ['content'] and ['bugs'] values for each changelog[N] actually
> get placed in changelog[N+1].  I.e. changelog[0] represents the topmost
> changelog entry but its changelog[0]['content'] and changelog[0]['bugs']
> are always empty; their values end up in changelog[1].
> 
> Fix the buggy debian.py changelog parser behavior and verify-release-ready's
> expectation of it.
> 
> IMPORTANT: Any other out-of-tree users of this debian.py changelog
> parser will see a behavior change w.r.t. the ['content'] and ['bugs']
> elements.
> 
> 
> PATCH 2/2: verify-release-ready: rename internal cl variables
> 
> No functional change; rename internal variables for sanity.
> 
> 
>  -Kamal
> 
> ----
> 
> Kamal Mostafa (2):
>   debian.py: fix changelog[content,bugs] off-by-one
>   verify-release-ready: rename internal cl variables
> 
>  ktl/debian.py                     |  41 +++++++------
>  maintscripts/verify-release-ready | 118 +++++++++++++++++++-------------------
>  py3/lib/debian.py                 |  33 ++++++-----
>  3 files changed, 102 insertions(+), 90 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180618/6857d14f/attachment.sig>


More information about the kernel-team mailing list