ACK/Cmnt: [PATCH][SRU Bionic][Unstable] scsi: hisi_sas: make SAS address of SATA disks unique

[Stefan Bader]

On 13.06.2018 22:00, dann frazier wrote:
> From: Xiang Chen <chenxiang66 at hisilicon.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1776750
> 
> When directly connected with SATA disks in different SAS cores, fill SAS
> address with scsi_host's id to make it's fake SAS address unique.
> 
> Signed-off-by: Xiang Chen <chenxiang66 at hisilicon.com>
> Signed-off-by: John Garry <john.garry at huawei.com>
> Signed-off-by: Martin K. Petersen <martin.petersen at oracle.com>
> (cherry picked from commit 8b8d66531555006a18d1532546dadbea8d16df95)
> Signed-off-by: dann frazier <dann.frazier at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---

ACK for Bionic [and unstable if needed], NACK for Artful as that reaches EOL
soon and should only get changes of high/critical importance.

-Stefan

>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> index 0215c2e3380e..5d6b5a73e6f7 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> @@ -3240,6 +3240,7 @@ static irqreturn_t sata_int_v2_hw(int irq_no, void *p)
>  	sas_phy->oob_mode = SATA_OOB_MODE;
>  	/* Make up some unique SAS address */
>  	attached_sas_addr[0] = 0x50;
> +	attached_sas_addr[6] = hisi_hba->shost->host_no;
>  	attached_sas_addr[7] = phy_no;
>  	memcpy(sas_phy->attached_sas_addr, attached_sas_addr, SAS_ADDR_SIZE);
>  	memcpy(sas_phy->frame_rcvd, fis, sizeof(struct dev_to_host_fis));
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180615/ae8bf029/attachment.sig>