ACK/cmnt: [PATCH v2 0/3][SRU Bionic] Decode ARM CPER records in kernel

[dann frazier]

On Mon, Jun 4, 2018 at 3:59 PM, Stefan Bader <stefan.bader at canonical.com> wrote:
> On 23.05.2018 17:05, dann frazier wrote:
>> Clean cherry-picks from upstream. Tested on a QDF2400 (the only ARM
>> system I know of that supports EINJ, needed for simulating errors).
>>
>> v2: Explicitly enable CONFIG_UEFI_CPER_ARM
>>
>> Tyler Baicar (2):
>>   efi: Move ARM CPER code to new file
>>   efi: Parse ARM error information value
>>
>> dann frazier (1):
>>   UBUNTU: [Config] CONFIG_UEFI_CPER_ARM=y
>>
>>  debian.master/config/config.common.ubuntu |   1 +
>>  drivers/firmware/efi/Kconfig              |   5 +
>>  drivers/firmware/efi/Makefile             |   1 +
>>  drivers/firmware/efi/cper-arm.c           | 356 ++++++++++++++++++++++
>>  drivers/firmware/efi/cper.c               | 122 +-------
>>  include/linux/cper.h                      |  48 +++
>>  6 files changed, 414 insertions(+), 119 deletions(-)
>>  create mode 100644 drivers/firmware/efi/cper-arm.c
>>
>
> Somehow more nice to have than required but ok, limited to specific arch and not
> too complex either. So only thing I probably would change is to have the patch
> changing the ubuntu config last.

Sorry, just noticed your feedback here. I actually used to put the
[Config] changes last, but noticed they were getting applied earlier.
Turns out there was a reason - bisection. IIRC, the idea is to avoid
having a commit where the Kconfig setting exists, but we haven't yet
defined it in the Ubuntu config.

  -dann