[SRU][Xenial][PATCH 0/1] UBUNTU: SAUCE: (no-up) virtio-scsi: Increment reqs counter.
Joseph Salisbury
joseph.salisbury at canonical.com
Fri Jun 8 17:48:26 UTC 2018
BugLink: http://bugs.launchpad.net/bugs/1775235
== SRU Justification ==
The bug reporter noticed that Xenial guests running on Nutanix AHV stopped
booting after they were upgraded to 4.4.0-127. Only guests with scsi mq
enabled suffered from this problem. AHV is one of the few hypervisor
products to offer multiqueue for virtio-scsi devices.
Upon further investigation, the saw that the kernel would hang during the
scanning of scsi targets. More specifically, immediately after coming
across a target without any luns present.
It was found the following commit introduced this regression:
commit f1f609d8015e1d34d39458924dcd9524fccd4307
Author: Jay Vosburgh <jay.vosburgh at canonical.com>
Date: Thu Apr 19 21:40:00 2018 +0200
The patch spins on the target's 'reqs' counter waiting for the target to quiesce.
Further study revealed that virtio-scsi itself is broken in a way that it
doesn't increment the 'reqs' counter when submitting requests on MQ in
certain conditions. That caused the counter to go to -1 (on the completion
of the first request) and the CPU to hang indefinitely.
This regression is fixed by the requested SAUCE patch.
== Fix ==
UBUNTU: SAUCE: (no-up) virtio-scsi: Increment reqs counter.
== Regression Potential ==
Low. Limited to virtio and fixes a regression.
== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.
Felipe Franciosi (1):
UBUNTU: SAUCE: (no-up) virtio-scsi: Increment reqs counter.
drivers/scsi/virtio_scsi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--
2.7.4
More information about the kernel-team
mailing list