[PATCH 1/3][SRU Bionic][Unstable] net: netsec: enable tx-irq during open callback

dann frazier dann.frazier at canonical.com
Fri Jun 8 16:52:18 UTC 2018


From: Jassi Brar <jaswinder.singh at linaro.org>

BugLink: https://bugs.launchpad.net/bugs/1775884

Enable TX-irq as well during ndo_open() as we can not count upon
RX to arrive early enough to trigger the napi. This patch is critical
for installation over network.

Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Jassi Brar <jaswinder.singh at linaro.org>
Signed-off-by: David S. Miller <davem at davemloft.net>
(cherry picked from commit c009f413b79de526a355b6eefa4f900b6c45d5f4)
Signed-off-by: dann frazier <dann.frazier at canonical.com>
---
 drivers/net/ethernet/socionext/netsec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index 6c263af86b8a..e9fc1a852446 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -1313,8 +1313,8 @@ static int netsec_netdev_open(struct net_device *ndev)
 	napi_enable(&priv->napi);
 	netif_start_queue(ndev);
 
-	/* Enable RX intr. */
-	netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX);
+	/* Enable TX+RX intr. */
+	netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX | NETSEC_IRQ_TX);
 
 	return 0;
 err3:
-- 
2.17.1





More information about the kernel-team mailing list