ACK[cmnt]: [SRU][A/B/OEM-A][PATCH] Enable mic-mute hotkey and led for Lenovo M810z, M820z and M920z

[Hui Wang]

On 2018年06月06日 06:58, Kleber Souza wrote:
> On 05/30/18 19:27, Hui Wang wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1774306
>>
>> Because of patch conflicting, I sent two patches in this thread:
>> 1st one is for artful and oem-artful kernel: [SRU][A/OEM-A][PATCH] ALSA: hda/realtek...
>> 2nd one is for bionic kernel: [SRU][B][PATCH] ALSA: hda/realtek...
>>
>> [Impact]
>> M810z, M820z and M920z are Lenovo AIO machines, there is a mic-mute button with
>> led on them, without this patch, the hotkey and led only works on M810z, if we
>> want 820z and 920z to work, we need to add their subsystem id in the driver, but
>> since they use same codec with same pin conf, we use a better way than adding id.
>>
>> [Fix]
>> With this patch, all 3 machines applied ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY.
>>
>> [Test Case]
>> press mic-mute button, then check sound-setting, we found the input will mute or
>> unmute as users press button, and led will on or off to indicate the input status.
>>
>> [Regression Potential]
>> Very low, through the strictly match the pin conf, codec id and vendor id, this
>> fix only apply to M810z, M820z and M920z.
>>
>> Hui Wang (1):
>>    ALSA: hda/realtek - Enable mic-mute hotkey for several Lenovo AIOs
>>
>>   sound/pci/hda/patch_realtek.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
> We only use "(cherry picked from commit ...)" if we can apply the patch
> cleanly by doing something like "git format-patch" and then "git am". If
> there are two different patches it means that at least one of them (if
> not both) had to be backported at least for context adjustments. In that
> case we use "(backported from commit ...)". Based on that, could you
> please indicate which of the two patches are "backports"?
>
> Anyway I'm giving my ACK, we can fix the provenance line when applying
> the patch.
>
> Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
Thanks for your instruction,  the 1st one patch ([SRU][A/OEM-A][PATCH] 
ALSA: hda/realtek...) should be added "backported from ...", I will fix 
it and send a patch of V2 to review.

thanks,
Hui.