NACK/cmnt: [PATCH][linux-meta][Unstable] Build linux-crashdump on arm64

[Stefan Bader]

On 05.06.2018 09:50, dann frazier wrote:
> On Mon, Jun 4, 2018 at 5:43 PM, Stefan Bader <stefan.bader at canonical.com> wrote:
>> On 25.05.2018 09:23, dann frazier wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1773407
>>>
>>> Signed-off-by: dann frazier <dann.frazier at canonical.com>
>>
>> When changing the meta-package tree we do not modify the changelog because that
>> is generated as part of the preparations for the next upload. And as benefit you
>> likely can use the same patch for all series.
> 
> OK. How is this done? That is, how do I ensure this change gets
> mentioned in debian/changelog w an LP: # ref.

When we prepare the meta package for upload, we will run the update script in
the tree which does create a new version number matching the abi of the kernel
and also inserts all changes since the last version like for the kernel.
So having a BugLink: line in the commit message will get you a

 * <bug title> (LP: #<bug number>)
   - <commit subject>

like you get with kernel commmits.

> 
>> Bikeshedding comment: maybe saying generate linux-crashdump meta-package for
>> arm64 is slightly better as this does not build anything in the binaries sense.
> 
> OK
> 
>> What I would like to see is more description in the commit message (like a short
>> summary of the reasoning of the change) which can be read without following bug
>> links.
> 
> No problem. For what it's worth, I didn't intend the BugLink to
> replace the commit text. Rather, I thought the "subject says it all",
> and just included the BugLink in case it's needed. I will come up with
> some text though. Should I include a formal BugLink URL like this, or
> just a (LP: #)?

The BugLink will get you the right mention in the changelog. The part about
verbose is for looking at the history with git log I find it more convenient to
have something like "We now can do crashdumps on arm64, so add the arch and the
additional dependency to the control file". So I don't have to click on a link
and then switch to the browser.

> 
>> Oh and personally I would prefer any re-submit be done as cover-letter style
>> with needed variations (if there are) as follow-ups. That is grouping things
>> better as its the same change over and over.
> 
> Sorry - I didn't follow this. I can do a cover-letter style if you
> prefer, but it's just one patch. Do you mean to mix releases in one
> patch series like this?:
> 
> [PATCH 0/3] Generate linux-crashdump metapackage for arm64
>  - [PATCH 1/3][Unstable] Generate linux-crashdump metapackage...
>  - [PATCH 2/3][SRU Bionic][SRU Artful] Generate linux-crashdump...
>  - [PATCH 3/3][SRU Xenial] Generate linux-crashdump metapackage...
> 
> If not - can you elaborate on what you mean by "needed variations"?
>

Yes, that was what I meant. This way it keeps the patches together in a thread
view of email clients. It is the same content more or less and I find it simpler
to look at submissions from a per bug report point of view.

-Stefan


> If the same patch applies everywhere, do you still want the cover
> letter, or is [PATCH v2] style fine?
> Thanks for reviewing!
> 
>   -dann
> 
>> -Stefan
>>
>>> ---
>>>  debian/changelog      | 6 ++++++
>>>  debian/control.common | 4 ++--
>>>  2 files changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/debian/changelog b/debian/changelog
>>> index 2239c07..1b53f40 100644
>>> --- a/debian/changelog
>>> +++ b/debian/changelog
>>> @@ -1,3 +1,9 @@
>>> +linux-meta (4.17.0.1.4) UNRELEASED; urgency=medium
>>> +
>>> +  * Build linux-crashdump on arm64 (LP: #1773407)
>>> +
>>> + -- dann frazier <dann.frazier at canonical.com>  Fri, 25 May 2018 10:08:01 -0600
>>> +
>>>  linux-meta (4.17.0.1.3) cosmic; urgency=medium
>>>
>>>    * Bump ABI 4.17.0-1
>>> diff --git a/debian/control.common b/debian/control.common
>>> index 6bacfdd..7e7fa80 100644
>>> --- a/debian/control.common
>>> +++ b/debian/control.common
>>> @@ -16,8 +16,8 @@ Description: Linux kernel source with Ubuntu patches
>>>   available. The Ubuntu patches have been applied.
>>>
>>>  Package: linux-crashdump at SUFFIX@
>>> -Architecture: i386 amd64 armhf ppc64el s390x
>>> -Depends: ${misc:Depends}, kdump-tools, grub-pc (>= 1.96+20090611-1ubuntu2) [i386 amd64] | grub-efi-ia32 [i386 amd64] | grub-efi-amd64 [i386 amd64] | grub (>= 0.97-29ubuntu24) [i386 amd64]
>>> +Architecture: i386 amd64 arm64 armhf ppc64el s390x
>>> +Depends: ${misc:Depends}, kdump-tools, grub-pc (>= 1.96+20090611-1ubuntu2) [i386 amd64] | grub-efi-ia32 [i386 amd64] | grub-efi-amd64 [i386 amd64] | grub-efi-arm64 [arm64] | grub (>= 0.97-29ubuntu24) [i386 amd64]
>>>  Recommends: apport
>>>  Suggests: crash
>>>  Description: Linux kernel crashdump setup for the latest generic kernel
>>>
>>
>>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180605/3754c076/attachment.sig>