ACK: [SRU][Artful][PULL v2] rfi-flush: Switch to new linear fallback flush

Kleber Souza kleber.souza at canonical.com
Tue Jun 5 16:43:48 UTC 2018


On 05/29/18 05:30, Juerg Haefliger wrote:
> v2: Updated patchset from IBM.
> 
> BugLink: https://bugs.launchpad.net/bugs/1744173
> 
> [Impact]
> Change flush method from "congruence-first with dependencies" to "linear with no dependencies", which increases flush performance by 8x on P8, and
> 3x on P9. Measured with null syscall loop, which will have the flush area in the L2 cache.
> 
> The flush also becomes simpler and more adaptable to different cache
> geometries.
> 
> [Test Case]
> TBD.
> 
> [Regression Potential]
> The risk is deemed low since the changes are confined to POWER only and the provided test kernels have been tested by IBM.
> 
> Signed-off-by: Juerg Haefliger <juergh at canonical.com>
> ---
> The following changes since commit 32f2fe36d1166cbd4ec673e4eb65321b14a564f7:
> 
>   UBUNTU: SAUCE: Set generic SSBD feature for Intel cpus (2018-05-28 16:11:59 +0200)
> 
> are available in the Git repository at:
> 
>   git://git.launchpad.net/~juergh/+git/artful-linux lp1744173-wave2
> 
> for you to fetch changes up to 59b29ce04397578d5e38547e4e42d21448f58136:
> 
>   powerpc/rfi-flush: Call setup_rfi_flush() after LPM migration (2018-05-29 14:01:55 +0200)
> 
> ----------------------------------------------------------------
> Gustavo Walbon (1):
>       UBUNTU: SAUCE: rfi-flush: Factor out init_fallback_flush()
> 
> Mauricio Faria de Oliveira (1):
>       powerpc/rfi-flush: Differentiate enabled and patched flush types
> 
> Michael Ellerman (3):
>       UBUNTU: SAUCE: rfi-flush: Move rfi_flush_fallback_area to end of paca
>       powerpc/rfi-flush: Make it possible to call setup_rfi_flush() again
>       powerpc/rfi-flush: Call setup_rfi_flush() after LPM migration
> 
> Nicholas Piggin (1):
>       powerpc/64s: Improve RFI L1-D cache flush fallback
> 
>  arch/powerpc/include/asm/paca.h           |  6 +--
>  arch/powerpc/include/asm/setup.h          |  2 +-
>  arch/powerpc/kernel/asm-offsets.c         |  3 +-
>  arch/powerpc/kernel/exceptions-64s.S      | 76 +++++++++++++++----------------
>  arch/powerpc/kernel/setup_64.c            | 59 ++++++++++++------------
>  arch/powerpc/platforms/pseries/mobility.c |  3 ++
>  arch/powerpc/platforms/pseries/pseries.h  |  2 +
>  arch/powerpc/platforms/pseries/setup.c    |  2 +-
>  8 files changed, 74 insertions(+), 79 deletions(-)
> 

Changes look good, tested by the vendor.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>




More information about the kernel-team mailing list