[PATCH 0/7] Fix an issue that makes r8169 fails to work after

[Kai Heng Feng]

> On Jun 5, 2018, at 6:03 AM, Stefan Bader <stefan.bader at canonical.com>  
> wrote:
>
> On 23.05.2018 21:35, Kai-Heng Feng wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1752772
>>
>> [Impact]
>> Ethernet r8169 stops working after system resumed from suspend.
>>
>> [Test]
>> User confirmed these patches fix the issue. r8169 continues to work
>> after resume from suspend.
>>
>> [Fix]
>> Patch 6/7 is the commit that fixes the issue.
>> Patch 7/7 fixes 6/7, also includes it.
>> Patches [1-5]/7 are dependencies to make 6/7 a clean cherry-pick.
>> Disabling WOL as default should be okay, here's the commit log:
>> "
>> Vast majority of users doesn't use WOL even if the BIOS enables it in
>> the chip. And having WOL being active keeps the PHY(s) from powering
>> down if being idle.
>> If somebody needs WOL, he can enable it during boot, e.g. by
>> configuring systemd.link/WakeOnLan.
>> "
>>
>> [Regression Potential]
>> Medium. The fix is limited to one device, all patches are in mainline.
>> The WOL default change might cause regression for users that depend on
>> BIOS settings. We can advice them to use userspace tool (systemd,
>> ethtool, etc.) instead.
>>
>> Heiner Kallweit (7):
>>   PCI: Add pcim_set_mwi(), a device-managed pci_set_mwi()
>>   r8169: switch to device-managed functions in probe
>>   r8169: remove netif_napi_del in probe error path
>>   r8169: remove some WOL-related dead code
>>   r8169: disable WOL per default
>>   r8169: improve interrupt handling
>>   r8169: fix interrupt number after adding support for MSI-X interrupts
>>
>>  drivers/net/ethernet/realtek/r8169.c | 178 +++++++--------------------
>>  drivers/pci/pci.c                    |  25 ++++
>>  include/linux/pci.h                  |   1 +
>>  3 files changed, 72 insertions(+), 132 deletions(-)
> Which kernel/series does this set target? Neither the submission nor the  
> bug
> report clearly say this.

Sorry I missed that.
This is for Bionic.
Should I send a V2 for this?

Kai-Heng

>
> -Stefan