NACK/cmnt: [PATCH][linux-meta][Unstable] Build linux-crashdump on arm64

[Stefan Bader]

On 25.05.2018 09:23, dann frazier wrote:
> BugLink: https://bugs.launchpad.net/bugs/1773407
> 
> Signed-off-by: dann frazier <dann.frazier at canonical.com>

When changing the meta-package tree we do not modify the changelog because that
is generated as part of the preparations for the next upload. And as benefit you
likely can use the same patch for all series.

Bikeshedding comment: maybe saying generate linux-crashdump meta-package for
arm64 is slightly better as this does not build anything in the binaries sense.

What I would like to see is more description in the commit message (like a short
summary of the reasoning of the change) which can be read without following bug
links.

Oh and personally I would prefer any re-submit be done as cover-letter style
with needed variations (if there are) as follow-ups. That is grouping things
better as its the same change over and over.

-Stefan

> ---
>  debian/changelog      | 6 ++++++
>  debian/control.common | 4 ++--
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/debian/changelog b/debian/changelog
> index 2239c07..1b53f40 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,9 @@
> +linux-meta (4.17.0.1.4) UNRELEASED; urgency=medium
> +
> +  * Build linux-crashdump on arm64 (LP: #1773407)
> +
> + -- dann frazier <dann.frazier at canonical.com>  Fri, 25 May 2018 10:08:01 -0600
> +
>  linux-meta (4.17.0.1.3) cosmic; urgency=medium
>  
>    * Bump ABI 4.17.0-1
> diff --git a/debian/control.common b/debian/control.common
> index 6bacfdd..7e7fa80 100644
> --- a/debian/control.common
> +++ b/debian/control.common
> @@ -16,8 +16,8 @@ Description: Linux kernel source with Ubuntu patches
>   available. The Ubuntu patches have been applied.
>  
>  Package: linux-crashdump at SUFFIX@
> -Architecture: i386 amd64 armhf ppc64el s390x
> -Depends: ${misc:Depends}, kdump-tools, grub-pc (>= 1.96+20090611-1ubuntu2) [i386 amd64] | grub-efi-ia32 [i386 amd64] | grub-efi-amd64 [i386 amd64] | grub (>= 0.97-29ubuntu24) [i386 amd64]
> +Architecture: i386 amd64 arm64 armhf ppc64el s390x
> +Depends: ${misc:Depends}, kdump-tools, grub-pc (>= 1.96+20090611-1ubuntu2) [i386 amd64] | grub-efi-ia32 [i386 amd64] | grub-efi-amd64 [i386 amd64] | grub-efi-arm64 [arm64] | grub (>= 0.97-29ubuntu24) [i386 amd64]
>  Recommends: apport
>  Suggests: crash
>  Description: Linux kernel crashdump setup for the latest generic kernel
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180604/eeec0131/attachment.sig>