NACK/Cmnt: [SRU][Bionic][PATCH 0/2] Fixes for LP:1777857

Stefan Bader stefan.bader at canonical.com
Tue Jul 17 14:28:38 UTC 2018


On 22.06.2018 18:22, Joseph Salisbury wrote:
> == SRU Justification ==
> IBM is seeing kernel traces during testing.  This is due to a missing 
> backport of some kernel fixes in the RTC driver, which is commit
> 682e6b4da5cb.  Commit 682e6b4da5cb was also cc'd to upstream stable, but
> it has not landed in Bionic as of yet.  It is also a fix to upstream
> commit 628daa8d5abf.
> 
> Commit 34dd25de9fe3 is also needed as a prereq to define
> OPAL_BUSY_DELAY_MS.
> 
> == Fixes ==
> 34dd25de9fe3 ("powerpc/powernv: define a standard delay for OPAL_BUSY type retry loops")
> 682e6b4da5cb ("rtc: opal: Fix OPAL RTC driver OPAL_BUSY loops")
> 
> == Regression Potential ==
> Low.  Limited to powerpc.  Fixes a current regression.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Nicholas Piggin (2):
>   powerpc/powernv: define a standard delay for OPAL_BUSY type retry
>     loops
>   rtc: opal: Fix OPAL RTC driver OPAL_BUSY loops
> 
>  arch/powerpc/include/asm/opal.h           |  3 +++
>  arch/powerpc/platforms/powernv/opal-rtc.c |  8 ++++---
>  drivers/rtc/rtc-opal.c                    | 37 +++++++++++++++++++------------
>  3 files changed, 31 insertions(+), 17 deletions(-)
> 
Rejecting for this bug, its already applied for LP: #1773964 (patch #2) and via
upstream stable. I am going to pull the patch from master-next into the
2018.07.02-5 re-spin.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180717/14c7bc8a/attachment.sig>


More information about the kernel-team mailing list