NACK: [Bionic][PATCH 0/2] Updates for Realtek ALC225

Khaled Elmously khalid.elmously at canonical.com
Wed Jan 31 18:58:21 UTC 2018


On 2018-01-29 22:47:01 , Wen-chien Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1723913
> BugLink: https://launchpad.net/bugs/1744058
> 
> One is an update to the previous commit, while the other is backported
> from maintainer's tree. Both commits are verified on a system with this
> device.
> 
> Kailang Yang (1):
>   ALSA: hda/realtek - update ALC225 depop optimize
> 
> Wen-chien Jesse Sung (1):
>   UBUNTU: SAUCE: ALSA: hda/realtek - Add support headset mode for DELL
>     WYSE
> 
>  sound/pci/hda/patch_realtek.c | 104 +++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 103 insertions(+), 1 deletion(-)
> 

NACK because:
 - Patch 1 should to be signed off properly by the author (as Seth pointed out)
 - Patch 2 should have a valid BugLink
 - Patch 2 should be marked as 'UBUNTU SAUCE' since it's not a mainline patch (that can be fixed by whoever is applying the patch, but if you're re-sending anyway for the above 2 reasons might as well fix that up too)

Thanks





More information about the kernel-team mailing list