[t x z a][PATCH 1/1] RDS: null pointer dereference in rds_atomic_free_op

Benjamin M Romer benjamin.romer at canonical.com
Wed Jan 31 16:47:59 UTC 2018


From: Mohamed Ghannam <simo.ghannam at gmail.com>

set rm->atomic.op_active to 0 when rds_pin_pages() fails
or the user supplied address is invalid,
this prevents a NULL pointer usage in rds_atomic_free_op()

Signed-off-by: Mohamed Ghannam <simo.ghannam at gmail.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar at oracle.com>
Signed-off-by: David S. Miller <davem at davemloft.net>

CVE-2018-5333
(cherry picked from commit 7d11f77f84b27cef452cee332f4e469503084737)
Signed-off-by: Benjamin M Romer <benjamin.romer at canonical.com>
---
 net/rds/rdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index 8d3a851a3476..f334692fcadd 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -866,6 +866,7 @@ int rds_cmsg_atomic(struct rds_sock *rs, struct rds_message *rm,
 err:
 	if (page)
 		put_page(page);
+	rm->atomic.op_active = 0;
 	kfree(rm->atomic.op_notifier);
 
 	return ret;
-- 
2.14.1





More information about the kernel-team mailing list