NACK: [SRU] [linux-oem] [PATCH 00/16] Fix out of bound VBT pin on CNP

Kai Heng Feng kai.heng.feng at canonical.com
Wed Jan 31 05:46:36 UTC 2018


> On 31 Jan 2018, at 1:42 PM, Kai-Heng Feng <kai.heng.feng at canonical.com> wrote:
> 
> [Impact]
> i915 crashed when probing for VBT pin. No graphics output after that.
> 
> [Test Case]
> Enable Legacy ROM boot option in BIOS. Screen goes blank.
> Cherrypick fixes can solve the issue.
> 
> [Fix]
> Handle out of bounds pin value more appropriately.
> Patches from Jani are most refactoring, but the fix we want depends on
> them.
> Patches from Rogrigo are the fixes we want. These patches are also
> picked base on his suggestion,
> https://bugs.freedesktop.org/show_bug.cgi?id=104139#c7
> 
> [Regression Potential]
> Low. CNL and CNP are still quite new. These commits are limited to them.
> 

Nack.
I forgot to add BugLinkā€¦ will resend a new one. 

> Jani Nikula (12):
>  drm/i914/bios: amend child device config parameters
>  drm/i915/bios: document BDB versions of child device config fields
>  drm/i915/bios: remove the raw version of child device config
>  drm/i915/bios: add legacy contents to common child device config
>  drm/i915/bios: throw away high level child device union
>  drm/i915/bios: throw away struct old_child_dev_config
>  drm/i915/bios: document child device config dvo_port values a bit
>    better
>  drm/i914/bios: group device type definitions together
>  drm/i915/bios: throw away unused DVO_* macros
>  drm/i915/bios: drop the rest of the p_ prefixes from pointers
>  drm/i915/bios: split up iboost to hdmi and dp bitfields
>  drm/i915/bios: add DP max link rate to VBT child device struct
> 
> Rodrigo Vivi (4):
>  drm/i915/cnl: Don't trust VBT's alternate pin for port D for now.
>  drm/i915/cnl: Map VBT DDC Pin to BSpec DDC Pin.
>  drm/i915/cnp: Ignore VBT request for know invalid DDC pin.
>  drm/i915/cnp: Properly handle VBT ddc pin out of bounds.
> 
> drivers/gpu/drm/i915/i915_drv.h       |   2 +-
> drivers/gpu/drm/i915/intel_bios.c     | 226 ++++++++++++++------------
> drivers/gpu/drm/i915/intel_vbt_defs.h | 295 +++++++++++++++++++---------------
> 3 files changed, 290 insertions(+), 233 deletions(-)
> 
> -- 
> 2.15.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team





More information about the kernel-team mailing list