ACK: [SRU][Artful][Bionic][PATCH 0/2] Fixes for LP:1743269

Colin Ian King colin.king at canonical.com
Tue Jan 23 17:55:15 UTC 2018


On 19/01/18 15:41, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1743269
> 
> == SRU Justification ==
> Commits b29c6ef7bb12 and 7d5905dc14a8 fix a regression in Artful.  They 
> were both added to mainline in v4.15-rc1 and fix the following two commits:
> b29c6ef7bb12 Fixes: 4815d3c56d1e (cpufreq: x86: Make scaling_cur_freq behave more as expected)
> 7d5905dc14a8 Fixes: 890da9cf0983 (Revert "x86: do not use cpufreq_quick_get() for /proc/cpuinfo "cpu MHz"")  
> According to the bug report, P-state is not working in Artful, but it was working 
> in Zesty.  This bug is happening on a Lenovo Thinkpad X230 with an Intel Core i5-3210M CPU.
> The bug reporter is using CPU scaling to improve battery life. 
> 
> == Fixes ==
> b29c6ef7bb12 ("x86 / CPU: Avoid unnecessary IPIs in arch_freq_get_on_cpu()")
> 7d5905dc14a8 ("x86 / CPU: Always show current CPU frequency in /proc/cpuinfo")
> 
> == Regression Potential ==
> Low.  The two commit fix a current regression and have had additiona upstream reviews
> from being send to stable.
> 
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> Rafael J. Wysocki (2):
>   x86 / CPU: Avoid unnecessary IPIs in arch_freq_get_on_cpu()
>   x86 / CPU: Always show current CPU frequency in /proc/cpuinfo
> 
>  arch/x86/kernel/cpu/Makefile     |  2 +-
>  arch/x86/kernel/cpu/aperfmperf.c | 71 +++++++++++++++++++++++++++++-----------
>  arch/x86/kernel/cpu/cpu.h        |  3 ++
>  arch/x86/kernel/cpu/proc.c       |  6 +++-
>  fs/proc/cpuinfo.c                |  6 ++++
>  include/linux/cpufreq.h          |  1 +
>  6 files changed, 68 insertions(+), 21 deletions(-)
> 

Good test results. Clean cherry pick, and it's in Bionic; gets my OK.

Acked-by: Colin Ian King <colin.king at canonical.com>




More information about the kernel-team mailing list