ACK: [SRU][Artful][PATCH 0/2] Fixes for LP:1742696

[Anthony Wong]

On Fri, Jan 19, 2018 at 11:19:59AM -0500, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1742696
> 
> == SRU Justification ==
> This bug was forked out of Bug #1734147 "corrupted BIOS due to Intel SPI 
> bug in kernel".  When trying to apply the fix in Bug #1734147 to a Lenovo 
> Yoga with Serial Flash s25fl064k, the actual fix works, however reverting 
> back to original available Kernel <4.14.x again locks the BIOS for write.
> 
> Explanation from Bug #1734147, Comment #524:
> "Commit d9018976cdb6 is missing with this particular BIOS/system because 
> every time you boot the system, the BIOS resets to default when it finds 
> BCR register is changed. This is different issue than the CMP=1 issue most 
> of the users have reported. This one also is not permanent so everything 
> is fine as long as you don't touch that BCR register. In this case you 
> either need to always boot to a kernel where that fix (d9018976cdb6) is 
> included or blacklist lpc_ich.ko. Ubuntu v4.14.x kernels have that fix 
> included so you might want to take one of them or build your own."
> 
> The two commits that fix this bug are already in Bionic, so they 
> are only needed in Artful.  Commit 9d63f17661e25f is also needed for this 
> issue and was cc'd to stable.  However, upstream 4.13 is EOL, so it is being
> requested in this SRU request.
> 
> == Fixes ==
> d9018976cdb6 ("mfd: lpc_ich: Do not touch SPI-NOR write protection bit on Haswell/Broadwell")
> 9d63f17661e2 ("spi-nor: intel-spi: Fix broken software sequencing codes")
> 
> == Regression Potential ==
> Low, these patches fix an existing critical regression.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> 
> Bin Meng (1):
>   spi-nor: intel-spi: Fix broken software sequencing codes
> 
> Mika Westerberg (1):
>   mfd: lpc_ich: Do not touch SPI-NOR write protection bit on
>     Haswell/Broadwell
> 
>  drivers/mfd/lpc_ich.c           | 10 ----------
>  drivers/mtd/spi-nor/intel-spi.c |  4 ++--
>  2 files changed, 2 insertions(+), 12 deletions(-)

Acked-by: Anthony Wong <anthony.wong at canonical.com>