[PATCH][SRU][linux-oem] Fix ASPM for all Realtek cardreader

AceLan Kao acelan.kao at canonical.com
Tue Jan 16 07:32:48 UTC 2018


BugLink: https://bugs.launchpad.net/bugs/1743516

[Impact]
Commit 8275b77a1513 ("mfd: rts5249: Add support for RTS5250S power saving") adds powersaving support for device-ids 5249 524a and 525a.
But as a side effect it breaks ASPM support for all the other device-ids, causing e.g. the Haswell CPU on a Lenovo T440s to not go into a higher c-state then PC3, while previously it would go to PC7, causing the machine to idle at 7.4W instead of 6.6W!

[Fix]
The default dev_aspm_mode 0 is mapped to DEV_ASPM_DISABLE, but the old behavior of calling rtsx_pci_enable_aspm() when idle and rtsx_pci_disable_aspm() when busy happens when dev_aspm_mode == DEV_ASPM_DYNAMIC.
This commit changes the enum so that 0 = DEV_ASPM_DYNAMIC matching the old default behavior, fixing the pm regression with the other device-ids.

[Regression Potential]
No, it fixes the regression and set it back to the old value, so should be no regression potential.

Hans de Goede (1):
  mfd: Fix RTS5227 (and others) powermanagement

 include/linux/rtsx_pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4





More information about the kernel-team mailing list