NAK: [PATCH][Bionic] iommu/arm-smmu-v3: Cope with duplicated Stream IDs
Seth Forshee
seth.forshee at canonical.com
Wed Jan 10 16:17:10 UTC 2018
On Mon, Jan 08, 2018 at 12:58:09PM -0700, dann frazier wrote:
> From: Robin Murphy <robin.murphy at arm.com>
>
> BugLink: https://bugs.launchpad.net/bugs/1741975
>
> For PCI devices behind an aliasing PCIe-to-PCI/X bridge, the bridge
> alias to DevFn 0.0 on the subordinate bus may match the original RID of
> the device, resulting in the same SID being present in the device's
> fwspec twice. This causes trouble later in arm_smmu_write_strtab_ent()
> when we wind up visiting the STE a second time and find it already live.
>
> Avoid the issue by giving arm_smmu_install_ste_for_dev() the cleverness
> to skip over duplicates. It seems mildly counterintuitive compared to
> preventing the duplicates from existing in the first place, but since
> the DT and ACPI probe paths build their fwspecs differently, this is
> actually the cleanest and most self-contained way to deal with it.
>
> Cc: <stable at vger.kernel.org>
> Fixes: 8f78515425da ("iommu/arm-smmu: Implement of_xlate() for SMMUv3")
> Reported-by: Tomasz Nowicki <tomasz.nowicki at caviumnetworks.com>
> Tested-by: Tomasz Nowicki <Tomasz.Nowicki at cavium.com>
> Tested-by: Jayachandran C. <jnair at caviumnetworks.com>
> Signed-off-by: Robin Murphy <robin.murphy at arm.com>
> Signed-off-by: Will Deacon <will.deacon at arm.com>
> (cherry picked from commit 563b5cbe334e9503ab2b234e279d500fc4f76018)
> Signed-off-by: dann frazier <dann.frazier at canonical.com>
Not a nak on the merits of the patch, however bionic already got this
patch from upstream stable so this patch is not needed.
More information about the kernel-team
mailing list