NACK/cmnt: [PATCH 1/4] UBUNTU: SAUCE: Redpine: fix wowlan issue

[Shrirang Bagul]

On Tue, 2018-01-09 at 12:37 +0530, Amitkumar Karwar wrote:
> On Tue, Jan 9, 2018 at 9:31 AM, Shrirang Bagul
> <shrirang.bagul at canonical.com> wrote:
> > Hi Amit,
> > 
> > Several issues with the submission of this patch series -
> > - It's a good practice to have a cover letter explaining the reason for the patch
> > series
> 
> I will take care of this in updated version.
Thanks.
> 
> > - BugLinks in the patch must point to public bugs against linux package.
> 
> Currently I am using below bugs in this patch series. Do you want me
> to add linux package for them or create new bugs against linux
> package?
> 
>  BugLink: https://bugs.launchpad.net/bugs/1736097
>  BugLink: https://bugs.launchpad.net/bugs/1738169
These are private bugs for internal tracking and cannot be accessed by everyone.
However, when you SRU patches, they are applied against https://launchpad.net/ubuntu/
+source/linux kernel which is open to all. Hence you'll have to file a bug against
this package.
One more detail I forgot to mention is, since these patches are against the Ubuntu
Xenial kernel, please include the '[X][SRU]' or '[Xenial SRU]' prefix in the subject
lines of the individual patches in the series.

/Shrirang
> 
> > 
> > Please refer to the SRU submission guidelines (see: https://wiki.ubuntu.com/Kerne
> > l/De
> > v/StablePatchFormat)
> > and resend the patches. I am NACKing this series.
> 
> Sure. I will go through the guidelines.
> 
> Regards,
> Amit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180109/91fc01fc/attachment.sig>