[SRU] [Xenial] [PATCH 10/14] nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA"

Kai-Heng Feng kai.heng.feng at canonical.com
Fri Jan 5 06:06:13 UTC 2018


From: Andy Lutomirski <luto at kernel.org>

BugLink: https://bugs.launchpad.net/bugs/1664602

There's a report that it malfunctions with APST on.

See https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678184

Cc: Kai-Heng Feng <kai.heng.feng at canonical.com>
Signed-off-by: Andy Lutomirski <luto at kernel.org>
Signed-off-by: Jens Axboe <axboe at fb.com>
(cherry picked from commit be56945c4edd5a3da15f8254b68d1ddb1588d0c4)
Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
---
 drivers/nvme/host/core.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 8fae040e0516..1ab61070b133 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1022,6 +1022,15 @@ struct nvme_core_quirk_entry {
 };
 
 static const struct nvme_core_quirk_entry core_quirks[] = {
+	{
+		/*
+		 * This Toshiba device seems to die using any APST states.  See:
+		 * https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678184/comments/11
+		 */
+		.vid = 0x1179,
+		.mn = "THNSF5256GPUK TOSHIBA",
+		.quirks = NVME_QUIRK_NO_APST,
+	}
 };
 
 /* match is null-terminated but idstr is space-padded. */
-- 
2.14.1





More information about the kernel-team mailing list