ACK/cmnt: [PATCH 0/5][linux-oem] Add Realtek 5260 card reader support

Shrirang Bagul shrirang.bagul at canonical.com
Thu Jan 4 03:57:25 UTC 2018


On Mon, 2017-12-25 at 17:09 +0800, AceLan Kao wrote:
> BugLink: http://bugs.launchpad.net/bugs/1737673
> 
> [Impact]
> Need new driver to support Realtek 5260 card reader[10ec:5260]
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=ib-mfd-memsti
> ck-misc-mmc-4.16&id=5da4e04ae480aac5274dd020af3dfa21935028f7
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=ib-mfd-memsti
> ck-misc-mmc-4.16&id=e455b69ddf9b69326d0cab28d374faf3325489c9
> 
> BTW, one more commit to fix symbol clashes is required, too
> https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=ib-mfd-
> memstick-misc-mmc-4.16&id=51bd7125f740a1bc9e79cd117d7d50f1dc67a446

Clean cherry picks from maintainers git tree. LGTM.

> [Fix]
> It requires 5 commits to enable the cardreader, and all of them are from v4.15-rc1
> or above.
> 
> [Test case]
> Verified on the new Readltek 5260 card reader[10ec:5260], and it can read MS card
> without issues.
> 
> [Regression Potential]
> Although it changes lots of files and changes the directories structure,
> the regression potential should be low, and only affects Realtek card reader only.
> 
> Rui Feng (3):
>   mfd: rts5249: Add support for RTS5250S power saving
>   misc: rtsx: Move Realtek Card Reader Driver to misc
>   misc: rtsx: Add support for RTS5260
> 
> Stephen Rothwell (1):
>   misc: rtsx: Fix symbol clashes
> 
> rui_feng (1):
>   mmc: rtsx: fix tuning fail on gen3 PCI-Express
> 
>  drivers/memstick/host/Kconfig       |    4 +-
>  drivers/memstick/host/rtsx_pci_ms.c |    2 +-
>  drivers/memstick/host/rtsx_usb_ms.c |    2 +-
>  drivers/mfd/Kconfig                 |   21 -
>  drivers/mfd/Makefile                |    4 -
>  drivers/mfd/rtl8411.c               |  508 -----------
>  drivers/mfd/rts5209.c               |  277 ------
>  drivers/mfd/rts5227.c               |  374 --------
>  drivers/mfd/rts5229.c               |  273 ------
>  drivers/mfd/rts5249.c               |  588 ------------
>  drivers/mfd/rtsx_pcr.c              | 1437 -----------------------------
>  drivers/mfd/rtsx_pcr.h              |   89 --
>  drivers/mfd/rtsx_usb.c              |  791 ----------------
>  drivers/misc/Kconfig                |    5 +
>  drivers/misc/Makefile               |    1 +
>  drivers/misc/cardreader/Kconfig     |   20 +
>  drivers/misc/cardreader/Makefile    |    4 +
>  drivers/misc/cardreader/rtl8411.c   |  508 +++++++++++
>  drivers/misc/cardreader/rts5209.c   |  277 ++++++
>  drivers/misc/cardreader/rts5227.c   |  374 ++++++++
>  drivers/misc/cardreader/rts5229.c   |  273 ++++++
>  drivers/misc/cardreader/rts5249.c   |  740 +++++++++++++++
>  drivers/misc/cardreader/rts5260.c   |  748 ++++++++++++++++
>  drivers/misc/cardreader/rts5260.h   |   45 +
>  drivers/misc/cardreader/rtsx_pcr.c  | 1690 +++++++++++++++++++++++++++++++++++
>  drivers/misc/cardreader/rtsx_pcr.h  |  113 +++
>  drivers/misc/cardreader/rtsx_usb.c  |  791 ++++++++++++++++
>  drivers/mmc/host/Kconfig            |    4 +-
>  drivers/mmc/host/rtsx_pci_sdmmc.c   |   40 +-
>  drivers/mmc/host/rtsx_usb_sdmmc.c   |    2 +-
>  include/linux/mfd/rtsx_common.h     |   50 --
>  include/linux/mfd/rtsx_pci.h        | 1056 ----------------------
>  include/linux/mfd/rtsx_usb.h        |  628 -------------
>  include/linux/rtsx_common.h         |   50 ++
>  include/linux/rtsx_pci.h            | 1367 ++++++++++++++++++++++++++++
>  include/linux/rtsx_usb.h            |  628 +++++++++++++
>  36 files changed, 7660 insertions(+), 6124 deletions(-)
>  delete mode 100644 drivers/mfd/rtl8411.c
>  delete mode 100644 drivers/mfd/rts5209.c
>  delete mode 100644 drivers/mfd/rts5227.c
>  delete mode 100644 drivers/mfd/rts5229.c
>  delete mode 100644 drivers/mfd/rts5249.c
>  delete mode 100644 drivers/mfd/rtsx_pcr.c
>  delete mode 100644 drivers/mfd/rtsx_pcr.h
>  delete mode 100644 drivers/mfd/rtsx_usb.c
>  create mode 100644 drivers/misc/cardreader/Kconfig
>  create mode 100644 drivers/misc/cardreader/Makefile
>  create mode 100644 drivers/misc/cardreader/rtl8411.c
>  create mode 100644 drivers/misc/cardreader/rts5209.c
>  create mode 100644 drivers/misc/cardreader/rts5227.c
>  create mode 100644 drivers/misc/cardreader/rts5229.c
>  create mode 100644 drivers/misc/cardreader/rts5249.c
>  create mode 100644 drivers/misc/cardreader/rts5260.c
>  create mode 100644 drivers/misc/cardreader/rts5260.h
>  create mode 100644 drivers/misc/cardreader/rtsx_pcr.c
>  create mode 100644 drivers/misc/cardreader/rtsx_pcr.h
>  create mode 100644 drivers/misc/cardreader/rtsx_usb.c
>  delete mode 100644 include/linux/mfd/rtsx_common.h
>  delete mode 100644 include/linux/mfd/rtsx_pci.h
>  delete mode 100644 include/linux/mfd/rtsx_usb.h
>  create mode 100644 include/linux/rtsx_common.h
>  create mode 100644 include/linux/rtsx_pci.h
>  create mode 100644 include/linux/rtsx_usb.h
> 
> -- 
> 2.7.4
Acked-by: Shrirang Bagul <shrirang.bagul at canonical.com>
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180104/3831adaf/attachment.sig>


More information about the kernel-team mailing list