ACK/cmnt: [PATCH 0/6][SRU Artful] Add support for ThunderX2 vendor PMU events

Stefan Bader stefan.bader at canonical.com
Wed Feb 28 10:10:39 UTC 2018


On 07.02.2018 01:07, dann frazier wrote:
> BugLink: https://bugs.launchpad.net/bugs/1747523
> 
> All clean cherry-picks except patch 2/6, which required some minimal
> backporting (details are documented in the S-o-b area). Tested on a Cavium
> Sabre board, and regression tested on x86 (Dell XPS13 9350).
> 
> Andi Kleen (1):
>   perf pmu: Extract function to get JSON alias map
> 
> Ganapatrao Kulkarni (5):
>   perf pmu: Pass pmu as a parameter to get_cpuid_str()
>   perf tools arm64: Add support for get_cpuid_str function.
>   perf pmu: Add helper function is_pmu_core to detect PMU CORE devices
>   perf vendor events arm64: Add ThunderX2 implementation defined pmu
>     core events
>   perf pmu: Add check for valid cpuid in perf_pmu__find_map()
> 
>  tools/perf/arch/arm64/util/Build                   |   1 +
>  tools/perf/arch/arm64/util/header.c                |  65 +++++++++++++
>  tools/perf/arch/powerpc/util/header.c              |   2 +-
>  tools/perf/arch/x86/util/header.c                  |   2 +-
>  .../arch/arm64/cavium/thunderx2-imp-def.json       |  62 ++++++++++++
>  tools/perf/pmu-events/arch/arm64/mapfile.csv       |  15 +++
>  tools/perf/util/header.h                           |   3 +-
>  tools/perf/util/pmu.c                              | 106 ++++++++++++++++-----
>  tools/perf/util/pmu.h                              |   2 +
>  9 files changed, 229 insertions(+), 29 deletions(-)
>  create mode 100644 tools/perf/arch/arm64/util/header.c
>  create mode 100644 tools/perf/pmu-events/arch/arm64/cavium/thunderx2-imp-def.json
>  create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv
> 
Acked-by: Stefan Bader <stefan.bader at canonical.com>

Generally feels a bit dangerous to introduce that much change for enablement. At
least it is "only" perf, so going wrong will at least not affect system stability.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180228/372b17e4/attachment.sig>


More information about the kernel-team mailing list