ACK: [SRU][Artful][PATCH 1/1] scsi: lpfc: Fix loop mode target discovery

[Stefan Bader]

On 16.02.2018 17:01, Joseph Salisbury wrote:
> From: Dick Kennedy <dick.kennedy at broadcom.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1746970
> 
> The driver does not discover targets when in loop mode.
> 
> The NLP type is correctly getting set when a fabric connection is
> detected but, not for loop. The unknown NLP type means that the driver
> does not issue a PRLI when in loop topology. Thus target discovery
> fails.
> 
> Fix by checking the topology during discovery.  If it is loop, set the
> NLP FC4 type to FCP.
> 
> Signed-off-by: Dick Kennedy <dick.kennedy at broadcom.com>
> Signed-off-by: James Smart <james.smart at broadcom.com>
> Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
> Signed-off-by: Martin K. Petersen <martin.petersen at oracle.com>
> (cherry picked from commit 2877cbffb79ed121a6bcc5edbe629d3aba36cd29)
> Signed-off-by: Joseph Salisbury <joseph.salisbury at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>

> ---
>  drivers/scsi/lpfc/lpfc_nportdisc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c
> index f74cb01..95b2b43 100644
> --- a/drivers/scsi/lpfc/lpfc_nportdisc.c
> +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c
> @@ -1724,6 +1724,9 @@ lpfc_cmpl_reglogin_reglogin_issue(struct lpfc_vport *vport,
>  				lpfc_nvme_update_localport(vport);
>  			}
>  
> +		} else if (phba->fc_topology == LPFC_TOPOLOGY_LOOP) {
> +			ndlp->nlp_fc4_type |= NLP_FC4_FCP;
> +
>  		} else if (ndlp->nlp_fc4_type == 0) {
>  			rc = lpfc_ns_cmd(vport, SLI_CTNS_GFT_ID,
>  					 0, ndlp->nlp_DID);
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180228/a96dfb29/attachment.sig>