ACK: [SRU][Artful][PATCH 0/1] delayacct: Account blkio completion on the correct task

Khaled Elmously khalid.elmously at canonical.com
Fri Feb 23 16:38:58 UTC 2018


On 2018-02-16 11:14:07 , Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1747769
> 
> == SRU Justification ==
> Mainline commit e33a9bba85a8 introduced a regression in v4.11-rc1.  This regression
> caused delayacct_blkio_end() to be called by try_to_wake_up().
> However, the call was made before we have context-switched. This patch is now correct, in that
> the delay accounting ends when the I/O is complete.
> 
> This commit has already landed in Bionic master-next, so it is only needed in Artful.
> 
> Commit c96f5471ce7 is in mainline as fo v4.15-rc9.
> 
> == Fix ==
> commit c96f5471ce7d2aefd0dda560cc23f08ab00bc65d
> Author: Josh Snyder <joshs at netflix.com>
> Date:   Mon Dec 18 16:15:10 2017 +0000
> 
>     delayacct: Account blkio completion on the correct task
> 
> == Regression Potential ==
> Low.  This commit has also been cc'd to stable, so it has had additional upstream
> review.
> 
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Josh Snyder (1):
>   delayacct: Account blkio completion on the correct task
> 
>  include/linux/delayacct.h |  8 ++++----
>  kernel/delayacct.c        | 42 ++++++++++++++++++++++++++----------------
>  kernel/sched/core.c       |  6 +++---
>  3 files changed, 33 insertions(+), 23 deletions(-)
> 

Acked-by: Khalid Elmously <khalid.elmously at canonical.com>





More information about the kernel-team mailing list