ACK/cmt / APPLIED[B]: [SRU][Artful][Bionic][linux-oem][PATCH v2 0/2] fix headset-mic detection problem for two Dell machines
seth.forshee at canonical.com
Tue Feb 13 14:32:04 UTC 2018
On Tue, Feb 13, 2018 at 09:28:52AM +0800, Hui Wang wrote:
> BugLink: https://launchpad.net/bugs/1748807
> In the v2, adding the alsa repository in the commit header for 0002-xxx.patch.
> We have two Dell machines which can't detect the headset microphone, as a result
> can't record sound via headset mic.
> One machchine has codec alc256, and there is already a quirk for this codec in the
> driver, we just add its pin definition to pin quirk table (0002-xxx.patch).
> The other machine has the codec alc289, we need the 0001-xxx.patch to let driver
> support headset mode for alc289 first, then we add its pin definition to pin quirk
> table (0002-xxx.patch)
> [Test Case]
> plug the headset and record the sound
> two upstream commits
> [Regression Potential]
> low, since the 0001-xxx.patch just adds vendor id to existing driver to let
> them support headset mode, it doesn't change existing functions, the 0002-xxx.patch
> adds a group of pin definition, it doesn't change existing funcitons too.
You need to add SRU justification to the bug, aside from that:
Acked-by: Seth Forshee <seth.forshee at canonical.com>
Applied to bionic/master-next, thanks!
More information about the kernel-team