ACK: [SRU][Artful][Bionic][linux-oem][PATCH 2/2] ALSA: hda - Fix headset mic detection problem for two Dell machines

[Aaron Ma]

On 02/12/2018 12:32 PM, Hui Wang wrote:
> On 2018年02月12日 12:25, Aaron Ma wrote:
>> On 02/12/2018 11:37 AM, Hui Wang wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1748807
>>>
>>> One of them has the codec of alc256 and the other one has the codec
>>> of alc289.
>>>
>>> Cc: <stable at vger.kernel.org>
>>> Signed-off-by: Hui Wang <hui.wang at canonical.com>
>>> Signed-off-by: Takashi Iwai <tiwai at suse.de>
>>> (cherry picked from commit 3f2f7c553d077be6a30cb96b2976a2c940bf5335)
> This is a new one, it is in the alsa repository now
> (git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git), and is
> going to be merged to mainline kernel soon.
> 

Good,
Acked-by: Aaron Ma <aaron.ma at canonical.com>


> Thanks,
> Hui.
> 
>> Didn't find this commit ID:
>>
>> The one with the same title is:
>>
>> commit 59ec4b57bcaede46546d54d037a21004b9aa5cef
>> Author: Hui Wang <hui.wang at canonical.com>
>> Date:   Thu Aug 4 15:28:04 2016 +0800
>>
>>      ALSA: hda - Fix headset mic detection problem for two dell machines
>>
>>      One of the machines has ALC255 on it, another one has ALC298 on it.
>>
>>      On the machine with the codec ALC298, it also has the speaker volume
>>      problem, so we add the fixup chained to ALC298_FIXUP_SPK_VOLUME
>> rather
>>      than adding a group of pin definition in the pin quirk table, since
>>      the speak volume problem does not happen on other machines yet.
>>
>>      Cc: <stable at vger.kernel.org>
>>      Signed-off-by: Hui Wang <hui.wang at canonical.com>
>>      Signed-off-by: Takashi Iwai <tiwai at suse.de>
>>
>> And there is a fix for it:
>> 2f726aec19a9d2c63bec9a8a53a3910ffdcd09f8
>>
>> It is already in oem branch.
>>
>> Regards,
>> Aaron
>>
>>
>>> Signed-off-by: Hui Wang <hui.wang at canonical.com>
>>> ---
>>>   sound/pci/hda/patch_realtek.c | 9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>>
>>> diff --git a/sound/pci/hda/patch_realtek.c
>>> b/sound/pci/hda/patch_realtek.c
>>> index 624d717..2eac412 100644
>>> --- a/sound/pci/hda/patch_realtek.c
>>> +++ b/sound/pci/hda/patch_realtek.c
>>> @@ -6549,6 +6549,11 @@ static const struct snd_hda_pin_quirk
>>> alc269_pin_fixup_tbl[] = {
>>>           {0x14, 0x90170110},
>>>           {0x21, 0x02211020}),
>>>       SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell",
>>> ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
>>> +        {0x12, 0x90a60130},
>>> +        {0x14, 0x90170110},
>>> +        {0x14, 0x01011020},
>>> +        {0x21, 0x0221101f}),
>>> +    SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell",
>>> ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
>>>           ALC256_STANDARD_PINS),
>>>       SND_HDA_PIN_QUIRK(0x10ec0256, 0x1043, "ASUS",
>>> ALC256_FIXUP_ASUS_MIC,
>>>           {0x14, 0x90170110},
>>> @@ -6617,6 +6622,10 @@ static const struct snd_hda_pin_quirk
>>> alc269_pin_fixup_tbl[] = {
>>>           {0x12, 0x90a60120},
>>>           {0x14, 0x90170110},
>>>           {0x21, 0x0321101f}),
>>> +    SND_HDA_PIN_QUIRK(0x10ec0289, 0x1028, "Dell",
>>> ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
>>> +        {0x12, 0xb7a60130},
>>> +        {0x14, 0x90170110},
>>> +        {0x21, 0x04211020}),
>>>       SND_HDA_PIN_QUIRK(0x10ec0290, 0x103c, "HP",
>>> ALC269_FIXUP_HP_MUTE_LED_MIC1,
>>>           ALC290_STANDARD_PINS,
>>>           {0x15, 0x04211040},
>>> -- 2.7.4
>>> -- kernel-team mailing list kernel-team at lists.ubuntu.com
>>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>>>
>