[PATCH 5/5][Unstable] net: socionext: Fix error return code in netsec_netdev_open()

dann frazier dann.frazier at canonical.com
Wed Feb 7 19:15:43 UTC 2018

From: Wei Yongjun <weiyongjun1 at huawei.com>

BugLink: https://bugs.launchpad.net/bugs/1747792

Fix to return error code -ENODEV from the of_phy_connect() error
handling case instead of 0, as done elsewhere in this function.

Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
(cherry picked from commit ecb10288a370b439e3b4552adea40d22900b9f64)
Signed-off-by: dann frazier <dann.frazier at canonical.com>
 drivers/net/ethernet/socionext/netsec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index af47147dd656..6c263af86b8a 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -1293,6 +1293,7 @@ static int netsec_netdev_open(struct net_device *ndev)
 				    netsec_phy_adjust_link, 0,
 				    priv->phy_interface)) {
 			netif_err(priv, link, priv->ndev, "missing PHY\n");
+			ret = -ENODEV;
 			goto err3;
 	} else {

More information about the kernel-team mailing list