APPLIED[A]: [Artful][linux-oem][PATCH 0/4] four audio fixes for Artful+linux-oem

[Khaled Elmously]

On 2018-02-02 12:21:10 , Kleber Souza wrote:
> Hi Khaled,
> 
> The commit for this patch is missing the ACK from Aaron Ma and your ACK
> as well.
> 
> 
> Thanks,
> Kleber

Hi Kleber

Thanks for the review.

I had discussed the detail of "SOB" vs "ACK" with Kamal, and he mentioned (hopefully I hadn't misunderstood) that SOB is equivalent to an ACK, and that if I'm signing-off on the commit then that automatically includes my ACK. In fact, he may have said that it's "undesirable" to have both - though I don't want to press this point too much in case I misunderstood him or am misquoting him.

This is also the reason I didn't include Aaron Ma's ACK in there, since there was already an ACK from Seth and me.

However, now with your latest feedback, I will ensure that I include both my ACKs and my SOBs for commits that I had personally ACK'd.

Thanks
-Khaled




> 
> On 02/01/18 21:54, Khaled Elmously wrote:
> > Applied to artful
> > 
> > On 2018-01-03 11:07:26 , Hui Wang wrote:
> >> patch [1/4] is for BugLink: http://bugs.launchpad.net/bugs/1740971
> >> patch [2/4] is for BugLink: http://bugs.launchpad.net/bugs/1740972
> >> patch [3/4] is for BugLink: http://bugs.launchpad.net/bugs/1740973
> >> patch [4/4] is for BugLink: http://bugs.launchpad.net/bugs/1740974
> >>
> >>
> >> patch [1/4] is for a bug filed in the Dell somerville project, without this patch,
> >> line-out jack can't work on this Dell machine.
> >>
> >> patch [2/4] is for a bug filed in the Dell somerville project too, without is patch,
> >> the external mic can't work through the headset jack on this machine.
> >>
> >> patch [3/4] is for a bug filed in the lenovo sutton project, without this patch,
> >> two front mics can't work since the pulseaudio can't handle two mics with the
> >> same name so far.
> >>
> >> patch [4/4] is for a bug filed in the HP stella project, without this patch, the
> >> external headset mic can record sound, but system can't detect its plug/unplug.
> >>
> >> [Impact]
> >> These bugs were filed against oem project, and they are certification blocker,
> >> and the fix for them is simple and straight-forward.
> >>
> >> [Test Case]
> >> Applying this patch and test the audio functions accordingly, all issues are fixed
> >> by proper patch.
> >>
> >> [Fix]
> >> Backport the uptream patch, the patch was CCed to stable as well.
> >>
> >> [Regression Potential]
> >> No, it does not change any existing functions.
> >>
> >>
> >> Hui Wang (3):
> >>   ALSA: hda - fix headset mic detection issue on a Dell machine
> >>   ALSA: hda - change the location for one mic on a Lenovo machine
> >>   ALSA: hda - Add MIC_NO_PRESENCE fixup for 2 HP machines
> >>
> >> Kailang Yang (1):
> >>   ALSA: hda/realtek - Fix Dell AIO LineOut issue
> >>
> >>  sound/pci/hda/patch_conexant.c | 29 +++++++++++++++++++++++++++++
> >>  sound/pci/hda/patch_realtek.c  | 41 ++++++++++++++++++++++++++++++++++++++++-
> >>  2 files changed, 69 insertions(+), 1 deletion(-)
> >>
> >> -- 
> >> 2.7.4
> >>
> >>
> >> -- 
> >> kernel-team mailing list
> >> kernel-team at lists.ubuntu.com
> >> https://lists.ubuntu.com/mailman/listinfo/kernel-team
> >