[SRU][Xenial][PATCH 0/2] Fixes for LP:1744078

Colin Ian King colin.king at canonical.com
Thu Feb 1 21:18:43 UTC 2018


On 01/02/18 21:14, Joseph Salisbury wrote:
> On 02/01/2018 04:04 PM, Colin Ian King wrote:
>> On 01/02/18 20:58, Joseph Salisbury wrote:
>>> BugLink: http://bugs.launchpad.net/bugs/1744078
>>>
>>> == SRU Justification ==
>>> On kernel versions < 4.8: x-netns vti is broken due to this bug.  This is resolved by the following commit:
>>> 11d7a0bb95ea ("xfrm: Only add l3mdev oif to dst lookups")     
>>>
>>> This is a regression introduced by: commit 42a7b32b73d6 ("xfrm: Add oif to dst lookups")
>>>
>>> Commit 1a8524794fc is also required as a prereq to fix build errors after picking
>>> commit 11d7a0bb95ea into Xenial.
>>>
>>> Commit 11d7a0bb95ea is in mainline as of v4.8-rc7.  It was also cc'd to upstream
>>> stable, but it never landed in upstream 4.4.y as of yet.
>>>
>>> == Fixes ==
>>> 1a8524794fc "(net: l3mdev: Add master device lookup by index)"
>>> 11d7a0bb95e "(xfrm: Only add l3mdev oif to dst lookups)"
>>>
>>> == Regression Potential ==
>>> Low.  These patches are required to fix an existing regression.
>>>
>>> == Test Case ==
>>> A test kernel was built with these patches and tested by the original bug reporter.
>>> The bug reporter states the test kernel resolved the bug.
>>>
>>> David Ahern (2):
>>>   net: l3mdev: Add master device lookup by index
>>>   xfrm: Only add l3mdev oif to dst lookups
>>>
>>>  include/net/l3mdev.h    | 23 +++++++++++++++++++++++
>>>  net/ipv4/xfrm4_policy.c |  2 +-
>>>  net/ipv6/xfrm6_policy.c |  2 +-
>>>  3 files changed, 25 insertions(+), 2 deletions(-)
>>>
>> Positive test results, clean upstream commits.
>>
>> One question, the report states "On kernel versions < 4.8: x-netns vti
>> is broken due to this bug..", does this need fixing on pre-Xenial LTS
>> kernels too?
>>
>> For Xenial:
>>
>> Acked-by: Colin Ian King <colin.king at canonical.com>
>>
> Thanks for the feedback, Colin.  This bug/regression was introduced by
> commit :
> 42a7b32b73d6 "(xfrm: Add oif to dst lookups)"
> 
> That commit was added to mainline in v4.3-rc1, and it was not cc'd to
> upstream stable.  This commit made it into Xenial, but never made it
> into Trusty(Or Precise) so it's only needed in Xenial. 
> 
Cool, thanks for the clarification!

Colin




More information about the kernel-team mailing list