[X][SRU][PATCH 0/1] selftests/cpu-hotplug: exit with failure when test occured unexpected behaviors

Po-Hsu Lin po-hsu.lin at canonical.com
Tue Dec 25 10:41:47 UTC 2018


BugLink: https://bugs.launchpad.net/bugs/1809699

== SRU Justification ==
This cpu-hotplug test will always return PASSED even if there are some failures there:

$ sudo make -C linux/tools/testing/selftests TARGETS=cpu-hotplug run_tests
make: Entering directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests'
for TARGET in cpu-hotplug; do \
 make -C $TARGET; \
done;
make[1]: Entering directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/cpu-hotplug'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/cpu-hotplug'
for TARGET in cpu-hotplug; do \
 make -C $TARGET run_tests; \
done;
make[1]: Entering directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/cpu-hotplug'
pid 25001's current affinity mask: 3
pid 25001's new affinity mask: 1
CPU online/offline summary:
  Cpus in online state: 0-1
  Cpus in offline state: 2
Limited scope test: one hotplug cpu
  (leaves cpu in the original state):
  online to offline to online: cpu 1
  offline to online to offline: cpu 2
./cpu-on-off-test.sh: line 78: /sys/devices/system/cpu/cpu2/online: No such file or directory
online_cpu_expect_success 2: unexpected fail
./cpu-on-off-test.sh: line 83: /sys/devices/system/cpu/cpu2/online: No such file or directory
offline_cpu_expect_success 2: unexpected fail
selftests: cpu-on-off-test.sh [PASS]
make[1]: Leaving directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/cpu-hotplug'
make: Leaving directory '/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests'

== Fixes ==
8fe6e53a8ed5f0 (selftests/cpu-hotplug: exit with failure when test occured unexpected behaviors)

For newer releases, they already have this patch.
For Trusty and older release, they will need more work to get this patch.

== Regression Potential ==
None, fix for testing tools.


Li Zhijian (1):
  selftests/cpu-hotplug: exit with failure when test occured unexpected
    behaviors

 tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.7.4




More information about the kernel-team mailing list