ACK: [SRU] [B/C/D/Unstable] [PATCH 0/2] Enable new Realtek card reader

[Kleber Souza]

On 12/3/18 7:27 AM, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1806335
>
> [Impact]
> USB Storage based Realtek card reader doesn't work, because the
> usb-storage module tries to use it in UAS mode instead of using
> "ums-realtek".
>
> [Fix]
> Add new IDs to ums-realtek driver.
> In addition to that, we add a new module knob, "enable_mmc=", to
> enable/disable MMC, as vendors may not pay MMC royalties. "enable_mmc"
> defaults to 1.
>
> [Test]
> After applying the patch, the card reader works, and verified
> "enable_mmc=" can enable/disable MMC support.
>
> [Regression Potential]
> Minimal. This SRU enables two specific card readers that don't work as
> UAS, the new module knob only introduces new behavior when enable_mmc=0.
>
> Kai-Heng Feng (2):
>   USB: usb-storage: Add new IDs to ums-realtek
>   UBUNTU: SAUCE: (noup) USB: usb-storage: Make MMC support optional on
>     ums-realtek
>
>  drivers/usb/storage/realtek_cr.c      | 36 +++++++++++++++++++++++++++
>  drivers/usb/storage/unusual_realtek.h | 10 ++++++++
>  2 files changed, 46 insertions(+)
>
Looks reasonable.


Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>