APPLIED: [Cosmic][SRU][PATCH 0/1] Fix for powerpc kernel selftest build issue

Khaled Elmously khalid.elmously at canonical.com
Thu Dec 20 07:57:18 UTC 2018


On 2018-12-14 17:39:57 , Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1808318
> 
> == Justification ==
> Commit b2d35fa5fc80 ("selftests: add headers_install to lib.mk")
> introduced a requirement that Makefiles more than one level below the
> selftests directory need to define top_srcdir, but it didn't update
> any of the powerpc Makefiles.
> 
> This broke building all the powerpc selftests with eg:
> 
>   make[1]: Entering directory '/src/linux/tools/testing/selftests/powerpc'
>   BUILD_TARGET=/src/linux/tools/testing/selftests/powerpc/alignment; mkdir -p $BUILD_TARGET; make OUTPUT=$BUILD_TARGET -k -C alignment all
>   make[2]: Entering directory '/src/linux/tools/testing/selftests/powerpc/alignment'
>   ../../lib.mk:20: ../../../../scripts/subarch.include: No such file or directory
>   make[2]: *** No rule to make target '../../../../scripts/subarch.include'.
>   make[2]: Failed to remake makefile '../../../../scripts/subarch.include'.
>   Makefile:38: recipe for target 'alignment' failed
> 
> 
> == Fix ==
> 7e0cf1c983b5 (selftests/powerpc: Fix Makefiles for headers_install change)
> It can be cherry-picked for Cosmic. Not needed for Disco as it already has this patch.
> 
> == Regression Potential ==
> None, this just fixes the broken build issue for the test. Nothing else will be affected.
> 
> 
> Michael Ellerman (1):
>   selftests/powerpc: Fix Makefiles for headers_install change
> 
>  tools/testing/selftests/powerpc/alignment/Makefile     | 1 +
>  tools/testing/selftests/powerpc/benchmarks/Makefile    | 1 +
>  tools/testing/selftests/powerpc/cache_shape/Makefile   | 1 +
>  tools/testing/selftests/powerpc/copyloops/Makefile     | 1 +
>  tools/testing/selftests/powerpc/dscr/Makefile          | 1 +
>  tools/testing/selftests/powerpc/math/Makefile          | 1 +
>  tools/testing/selftests/powerpc/mm/Makefile            | 1 +
>  tools/testing/selftests/powerpc/pmu/Makefile           | 1 +
>  tools/testing/selftests/powerpc/pmu/ebb/Makefile       | 1 +
>  tools/testing/selftests/powerpc/primitives/Makefile    | 1 +
>  tools/testing/selftests/powerpc/ptrace/Makefile        | 1 +
>  tools/testing/selftests/powerpc/signal/Makefile        | 1 +
>  tools/testing/selftests/powerpc/stringloops/Makefile   | 1 +
>  tools/testing/selftests/powerpc/switch_endian/Makefile | 1 +
>  tools/testing/selftests/powerpc/syscalls/Makefile      | 1 +
>  tools/testing/selftests/powerpc/tm/Makefile            | 1 +
>  tools/testing/selftests/powerpc/vphn/Makefile          | 1 +
>  17 files changed, 17 insertions(+)
> 
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list