ACK/Cmnt: [SRU bionic/master-next 1/1 V2] UBUNTU: SAUCE: base/dd: limit release function changes to vfio driver only

Andy Whitcroft apw at canonical.com
Thu Dec 6 12:57:14 UTC 2018


On Thu, Dec 06, 2018 at 01:52:55PM +0100, Stefan Bader wrote:
> On 06.12.18 13:32, Andy Whitcroft wrote:
> > It seems that we can trigger the new race detection after remove()
> > with some drivers which clear the driver as they unreference
> > the module.  This leads us to fail to clear down those devices which
> > triggers suspend/resume issues.
> > 
> > Limit the core changes to only apply to the vfio driver while we
> > work with upstream on a more generic fix.
> > 
> > Fixes: 876dcb5f4576 ("UBUNTU: SAUCE: vfio -- release device lock before userspace requests")
> > BugLink: http://bugs.launchpad.net/bugs/1803942
> > Signed-off-by: Andy Whitcroft <apw at canonical.com>
> Acked-by: Stefan Bader <stefan.bader at canonical.com>
> > ---
> 
> I guess this is better as the variable is now located in the base driver and
> thus exists regardless of the vfio driver being loaded. Not sure whether the
> pci_unregister_driver call in vfio would still want the pointer set. But if that
> sounds ok to you I am good with that.

I do not believe it needs it.  This is not something many configurations
can even trigger and removing the driver is not something most people
would do in the normal run of things.

-apw



More information about the kernel-team mailing list