ACK/Cmnt: [PATCH 1/1] lan78xx: Move enabling of EEE into PHY init code

Paolo Pisati paolo.pisati at canonical.com
Wed Dec 5 17:43:23 UTC 2018


On Wed, Dec 5, 2018 at 5:57 PM Stefan Bader <stefan.bader at canonical.com> wrote:
>
> I would add "cosmic" to the second pick on commit, but also where is the first
> pick from? Does not seem to be linus tree.

For the Bionic point of view, it comes from Cosmic/raspi2 (since
that's where i'm cherry-picking), but originally it came from
Raspberry Pi's github tree / rpi-4.18.y branch

They keep rebasing so that sha1 is no more, but here it is:
https://github.com/raspberrypi/linux/commit/4efb959af4904f09810f4f98a65a4dbc91f0f0d2

commit 4efb959af4904f09810f4f98a65a4dbc91f0f0d2
Author: Phil Elwell <phil at raspberrypi.org>
Date:   Thu Apr 5 14:46:11 2018 +0100

    lan78xx: Move enabling of EEE into PHY init code

    Enable EEE mode as soon as possible after connecting to the PHY, and
    before phy_start. This avoids a second link negotiation, which speeds
    up booting and stops the interface failing to become ready.

    See: https://github.com/raspberrypi/linux/issues/2437

    Signed-off-by: Phil Elwell <phil at raspberrypi.org>



More information about the kernel-team mailing list