ACK / APPLIED[D]: [SRU disco/cosmic/bionic] linux-buildinfo getabis enhancements

Seth Forshee seth.forshee at canonical.com
Wed Dec 5 04:19:53 UTC 2018


On Tue, Dec 04, 2018 at 09:32:00PM +0000, Andy Whitcroft wrote:
> In reviewing the linux-buildinfo support it was pointed out that getabis
> would have problems at the transition from one form to the other.  We have
> also long had a problem with errors during downloads being hidden from the
> user (as we expect some configurations to not have all of the packages).
> This leads us to commit partial ABI information and us to have build
> failures which could be avoided.
> 
> This patch kit does four things.  Firstly it adds descrimination
> of download failures, separating transport failures (which it makes
> instantly fatal) from server generated failures (404 etc).  Secondly it
> uses this discrimination to allow us to identify the presence of valid
> combinations of packages and avoid partial ABI downloads.  Thirdly it
> uses this ability to identify valid combinations to iterate over the
> combinations valid in any series, allowing us to use the same getabis
> script for all series unmodified.  Finally it adds support for parsing
> complete version numbers to simply execution.
> 
> Proposing for application on top of the linux-buildinfo fixes on disco,
> cosmic, and bionic.

Looks good to me, seems to be working for disco/master-next at least.

Acked-by: Seth Forshee <seth.forshee at canonical.com>

Applied to disco/master-next, thanks!



More information about the kernel-team mailing list