[PATCH] [SRU][B/raspi2] snapcraft.yaml: skip non-existent firmware_install step

Paolo Pisati paolo.pisati at canonical.com
Thu Aug 30 12:56:52 UTC 2018


BugLink: https://bugs.launchpad.net/bugs/1789897

[Impact]

Linux kernel removed the 'firmware_install' step long ago (~4.13), so invoking
it results in a broken kernel snap build:

...
make -j4 CONFIG_PREFIX=/build/pc-kernel/parts/kernel/install modules_install
INSTALL_MOD_PATH=/build/pc-kernel/parts/kernel/install dtbs_install
INSTALL_DTBS_PATH=/build/pc-kernel/parts/kernel/install/dtbs firmware_install
INSTALL_FW_PATH=/build/pc-kernel/parts/kernel/install/lib/firmware Failed to run
'make -j4 CONFIG_PREFIX=/build/pc-kernel/parts/kernel/install modules_install
INSTALL_MOD_PATH=/build/pc-kernel/parts/kernel/install dtbs_install
INSTALL_DTBS_PATH=/build/pc-kernel/parts/kernel/install/dtbs firmware_install
INSTALL_FW_PATH=/build/pc-kernel/parts/kernel/install/lib/firmware' for
'kernel': Exited with code 2.  Verify that the part is using the correct
parameters and try again.

During the last snapcraft patch, i accidentally removed the directive to skip
it.

[Fix]

Apply the attached patch

[Test]

Try to snap a kernel:

$ snapcraft --target-arch=arm

...
The version has been set to '4.15.0-1022.24'
Snapping 'pi2-kernel' |
Snapped pi2-kernel_4.15.0-1022.24_armhf.snap

[Regression]

None, it actually fixes a regression.

Paolo Pisati (1):
  UBUNTU: snapcraft.yaml: skip non-existent firmware_install step

 snapcraft.yaml | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.4





More information about the kernel-team mailing list