ACK/Cmnt: [SRU] [Bionic/Unstable] [PATCH v2 0/4] Enable AMD PCIe MP2 for AMDI0011
kai.heng.feng at canonical.com
Thu Aug 30 09:43:38 UTC 2018
at 17:23, Stefan Bader <stefan.bader at canonical.com> wrote:
> On 19.07.2018 12:19, Kai-Heng Feng wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1773940
>> Touchpad doesn't work on Latitude 5495.
>> I can confirm the driver from AMD works.
>> With patch 2/3, no issues found so far.
>> The touchpad connects to AMDI0011, which doesn't have any driver until
>> The original plan is to use an upstream version for this driver, but the
>> review process took longer than anticipated, and the driver is really in
>> need as the Latitude 5495 is about to hit the market. I'll replace this
>> patch set with upstream version once it's in mainline.
>> v2: Fix build for architectures don't support ACPI.
>> [Regression Potential]
>> Low. It's a new driver, shouldn't affect any other device.
>> Kai-Heng Feng (3):
>> UBUNTU: SAUCE: i2c:amd move out pointer in union i2c_event_base
>> UBUNTU: SAUCE: i2c:amd Depends on ACPI
>> UBUNTU: [Config] i2c: CONFIG_I2C_AMD_MP2=y
>> Nehal-bakulchandra Shah (1):
>> UBUNTU: SAUCE: i2c:amd I2C Driver based on PCI Interface for upcoming
>> debian.master/config/config.common.ubuntu | 1 +
>> drivers/i2c/busses/Kconfig | 10 +
>> drivers/i2c/busses/Makefile | 2 +
>> drivers/i2c/busses/i2c-amd-pci-mp2.c | 625 ++++++++++++++++++++++
>> drivers/i2c/busses/i2c-amd-pci-mp2.h | 253 +++++++++
>> drivers/i2c/busses/i2c-amd-platdrv.c | 335 ++++++++++++
>> 6 files changed, 1226 insertions(+)
>> create mode 100644 drivers/i2c/busses/i2c-amd-pci-mp2.c
>> create mode 100644 drivers/i2c/busses/i2c-amd-pci-mp2.h
>> create mode 100644 drivers/i2c/busses/i2c-amd-platdrv.c
> Ok, there is probably no choice but to build the driver into the kernel.
> But at
> least I would suggest to limit this to x86 kernels. So replacing patch
> 4/4 with
> the attached version. How does that sound (I am also adding the update to
> annotations file)?
This makes sense and it's probably the best approach in the interim.
> Acked-by: Stefan Bader <stefan.bader at canonical.com>
More information about the kernel-team