ACK: [PATCH 1/1] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

[Shrirang Bagul]

On Mon, 2018-08-27 at 17:23 +0000, Kai-Heng Feng wrote:
> From: Kai Heng Feng <kai.heng.feng at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1762385
> 
> There are two new events generated by dell-wmi, rfkill and fn-lock, from
> Dell Systems.
> 
> When Fn-lock hotkey gets pressed to switch to function mode:
> [85951.591542] dell_wmi: Unknown key with type 0x0010 and code 0xe035
> pressed
> [85951.591546] dell_wmi: Unknown key with type 0x0010 and code 0x0000
> pressed
> 
> When Fn-lock hotkey gets pressed to switch to multimedia mode:
> [85956.667686] dell_wmi: Unknown key with type 0x0010 and code 0xe035
> pressed
> [85956.667690] dell_wmi: Unknown key with type 0x0010 and code 0x0001
> pressed
> 
> When radio hotkey gets pressed:
> [85974.430220] dell_wmi: Unknown key with type 0x0010 and code 0xe008
> pressed
> 
> These events are for notification purpose, so we can ignore them.
> 
> This patch is tested on XPS 9370.
> 
> Reviewed-by: Pali Rohár <pali.rohar at gmail.com>
> Reviewed-by: Mario Limonciello <mario.limonciello at dell.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> (backported from commit 64b824649b7787c9ac491015f16ffa4ad2ec287e)
> Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>

Acked-by: Shrirang Bagul <shrirang.bagul at canonical.com>

> ---
>  drivers/platform/x86/dell-wmi.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index fb25b20df316..3a920381cccd 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -261,6 +261,12 @@ static const u16 bios_to_linux_keycode[256] = {
>   * override them.
>   */
>  static const struct key_entry dell_wmi_keymap_type_0010[] = {
> +	/* Fn-lock switched to function keys */
> +	{ KE_IGNORE, 0x0, { KEY_RESERVED } },
> +
> +	/* Fn-lock switched to multimedia keys */
> +	{ KE_IGNORE, 0x1, { KEY_RESERVED } },
> +
>  	/* Fn-lock */
>  	{ KE_IGNORE, 0x151, { KEY_RESERVED } },
>  
> @@ -293,6 +299,14 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
>  	{ KE_KEY,    0x851, { KEY_PROG2 } },
>  	{ KE_KEY,    0x852, { KEY_PROG3 } },
>  
> +	/*
> +	 * Radio disable (notify only -- there is no model for which the
> +	 * WMI event is supposed to trigger an action).
> +	 */
> +	{ KE_IGNORE, 0xe008, { KEY_RFKILL } },
> +
> +	/* Fn-lock */
> +	{ KE_IGNORE, 0xe035, { KEY_RESERVED } },
>  };
>  
>  /*
> -- 
> 2.17.1
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180830/04ec3597/attachment.sig>