[kteam-tools][PATCH] create-stable-tracker: --version 'patchset' option for arbitrary patch sets
kamal at canonical.com
Mon Aug 27 17:01:31 UTC 2018
On Mon, Aug 27, 2018 at 3:42 AM Stefan Bader <stefan.bader at canonical.com>
> I do not understand the changes made in this hunk. At least not why they
> be made along with the other changes.
> > ubuntu = lp.distributions["ubuntu"]
> > sc = ubuntu.series_collection
> > for s in sc:
> > - if s.name == series_name.title():
> > + if s.name == series_name:
That series_name test was just broken (probably never worked) because
series_name.title() yields a capitalized series name but the
series_collection.name values are lowercase, e.g. it tests "bionic" ==
"Bionic". This fixes the test -- but you're right, it doesn't relate to
this commit's new feature. I'll split it out and resubmit.
Same for the fix below to the staging bug link: an unrelated fix.
> nomination = bug.lpbug.addNomination(target=s)
> > if nomination.canApprove():
> > nomination.approve()
> > if 'staging' in self.cfg:
> > - print("https://bugs.qastaging.launchpad.net/bugs/%s" %
> > + print("https://bugs.%s.launchpad.net/bugs/%s" %
> (self.defaults['launchpad_services_root'], bug.id))
> > else:
> > print("https://bugs.launchpad.net/bugs/%s" % (bug.id))
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the kernel-team