ACK/Cmnt: [SRU] [Bionic] [PATCH 0/3] Fix for r8169 connection issue

Stefan Bader stefan.bader at canonical.com
Mon Aug 27 13:20:29 UTC 2018


On 27.08.2018 06:36, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1779817
> 
> [Impact]
> r8169 failed to establish connection after the fix for LP: #1752772
> landed.
> 
> [Fix]
> Accepts BIOS WoL settings again, and disables MSI-X for certain chip
> revisions.
> 
> [Test]
> Users confirmed the fix worked for them.
> 
> [Regression Potential]
> Low. This brings back the old behavior for both WoL and MSI.
> 
> Heiner Kallweit (2):
>   r8169: restore previous behavior to accept BIOS WoL settings
>   r8169: don't use MSI-X on RTL8168g
> 
> Jian-Hong Pan (1):
>   r8169: don't use MSI-X on RTL8106e
> 
>  drivers/net/ethernet/realtek/r8169.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 

Patches look ok to me. But patches #2 and #3 are from 4.19-rc1, so there is a
chance that they also should be picked up for Cosmic/unstable in order to avoid
regressions there.

I added Thadeu and Seth to cc. Apart from this,

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180827/3f61999e/attachment.sig>


More information about the kernel-team mailing list