[PATCH] [SRU][X/raspi2] Fix build with snapcraft 2.42.1

Khaled Elmously khalid.elmously at canonical.com
Fri Aug 24 03:01:50 UTC 2018


On 2018-08-06 16:50:45 , Paolo Pisati wrote:
> BugLink: http://bugs.launchpad.net/bugs/1785647
> 
> Impact:
> 
> Xenial/raspi2 kernel snap fails to build with latest snapcraft release (2.42.1):
> 
> https://launchpadlibrarian.net/382070508/buildlog_snap_ubuntu_xenial_arm64_piso-xenial-snapdragon-dummy_BUILDING.txt.gz
> 
> ...
> Selecting previously unselected package snapcraft.
> Preparing to unpack .../snapcraft_2.42.1_all.deb ...
> Unpacking snapcraft (2.42.1) ...
> ...
> Running pull phase...
> Issues while validating None: The 'parts/kernel' property does not match the
> required schema: Parts cannot contain both 'install' and 'override-*' keywords.
> Use 'override-build' instead of 'install'.
> Build failed
> ...
> 
> that is due to the deprecation of the 'prepare, build and install' targets and
> their inability to coexist with the newer 'override-build' target.
> 
> Fix:
> 
> Apply the attached patch and snap again:
> 
> https://launchpadlibrarian.net/382085652/buildlog_snap_ubuntu_xenial_armhf_piso-xenial-raspi2-dummy_BUILDING.txt.gz
> 
> this time it'll snap fine.
> 
> Regression:
> 
> It fixes the build, so none.
> 
> Paolo Pisati (1):
>   UBUNTU: snapcraft.yaml: convert prepare, build and install to
>     override-build
> 
>  snapcraft.yaml | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 

Paolo - this patch doesn't seem to apply cleanly to xenial/raspi2

I don't know if there's an earlier patch on the ML that I'm supposed to apply first (I looked but couldn't find one).

I'm not very confident that I've resolved the conflict correctly. 

This is the diff that I now have: 
https://pastebin.canonical.com/p/YnbCKhKf3k/   

And this is the final snapcraft.yaml file:
https://pastebin.canonical.com/p/DJv7tzcDmm/


Could you please confirm if this is correct (or maybe send a v2 if it's not)?
Thanks

Khaled




More information about the kernel-team mailing list