NAK: [PATCH] UBUNTU: [Config] disable ARCH_TANGO

Seth Forshee seth.forshee at
Thu Aug 23 20:08:46 UTC 2018

On Thu, Aug 23, 2018 at 12:43:23PM +0200, Paolo Pisati wrote:
> BugLink:
> Impact:
> The TANGO platform (an embedded soc used in home entertainment, connectivity and
> control devices) is enabled by default in the generic arm kernel. During kernel
> bootup, the tango platform blindly registers its pm ops in
> arch/arm/mach-tango/pm.c via initcalls() (without checking whether it's actually
> running on the correspondent hardware) and this causes OOPS during suspend on
> tegra platforms since the tango pm .enter function directly pokes the underlying
> hardware.
> Given the narrow scope of this SOC, i propose to disable support for the TANGO
> arch.
> Fix:
> Apply the attached patch and recompile.
> How to test:
> Suspend the tegra board and chek that it worked.
> Signed-off-by: Paolo Pisati <paolo.pisati at>

This seems fine, except that I think it also needs to enforce
CONFIG_ARCH_TANGO=n in the annotations to prevent any accidental changes
to the option.

I'm guessing we should also change these configs in cosmic and unstable?


More information about the kernel-team mailing list